From owner-svn-src-all@FreeBSD.ORG  Tue Jan 17 16:10:42 2012
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A5E75106566B;
	Tue, 17 Jan 2012 16:10:42 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42])
	by mx1.freebsd.org (Postfix) with ESMTP id 7CAF08FC0C;
	Tue, 17 Jan 2012 16:10:42 +0000 (UTC)
Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [96.47.65.170])
	by cyrus.watson.org (Postfix) with ESMTPSA id 34C9E46B2C;
	Tue, 17 Jan 2012 11:10:42 -0500 (EST)
Received: from jhbbsd.localnet (unknown [209.249.190.124])
	by bigwig.baldwin.cx (Postfix) with ESMTPSA id B4F3DB91C;
	Tue, 17 Jan 2012 11:10:41 -0500 (EST)
From: John Baldwin <jhb@freebsd.org>
To: Kevin Lo <kevlo@freebsd.org>
Date: Tue, 17 Jan 2012 11:05:22 -0500
User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p10; KDE/4.5.5; amd64; ; )
References: <201201161025.q0GAPNDq027693@svn.freebsd.org>
	<201201170950.15267.jhb@freebsd.org>
In-Reply-To: <201201170950.15267.jhb@freebsd.org>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <201201171105.23029.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7
	(bigwig.baldwin.cx); Tue, 17 Jan 2012 11:10:41 -0500 (EST)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r230208 - head/sys/fs/tmpfs
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 17 Jan 2012 16:10:42 -0000

On Tuesday, January 17, 2012 9:50:15 am John Baldwin wrote:
> On Monday, January 16, 2012 5:25:23 am Kevin Lo wrote:
> > Author: kevlo
> > Date: Mon Jan 16 10:25:22 2012
> > New Revision: 230208
> > URL: http://svn.freebsd.org/changeset/base/230208
> > 
> > Log:
> >   Add nfs export support to tmpfs(5)
> >   
> >   Reviewed by:	kib
> > 
> > Modified:
> >   head/sys/fs/tmpfs/tmpfs_vfsops.c
> > 
> > Modified: head/sys/fs/tmpfs/tmpfs_vfsops.c
> > 
> ==============================================================================
> > --- head/sys/fs/tmpfs/tmpfs_vfsops.c	Mon Jan 16 09:53:24 2012	(r230207)
> > +++ head/sys/fs/tmpfs/tmpfs_vfsops.c	Mon Jan 16 10:25:22 2012	(r230208)
> > @@ -150,10 +150,8 @@ tmpfs_mount(struct mount *mp)
> >  		return (EINVAL);
> >  
> >  	if (mp->mnt_flag & MNT_UPDATE) {
> > -		/* XXX: There is no support yet to update file system
> > -		 * settings.  Should be added. */
> > -
> > -		return EOPNOTSUPP;
> > +		if (vfs_flagopt(mp->mnt_optnew, "export", NULL, 0))
> > +			return (0);
> >  	}
> 
> Is it supposed to fall through if the 'export' option isn't in the list during 
> an update mount?

Nevermind, was supposed to have deleted this from my pending send queue before
it went out.  This was fixed in a subsequent commit.

-- 
John Baldwin