From owner-cvs-all@FreeBSD.ORG Mon Jul 19 13:25:15 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 84AF216A4CF for ; Mon, 19 Jul 2004 13:25:15 +0000 (GMT) Received: from mail3.speakeasy.net (mail3.speakeasy.net [216.254.0.203]) by mx1.FreeBSD.org (Postfix) with ESMTP id 60E1643D5C for ; Mon, 19 Jul 2004 13:25:15 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: (qmail 24617 invoked from network); 19 Jul 2004 13:25:15 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 19 Jul 2004 13:25:12 -0000 Received: from slimer.baldwin.cx (slimer.baldwin.cx [192.168.0.16]) (authenticated bits=0) by server.baldwin.cx (8.12.11/8.12.11) with ESMTP id i6JDOh6h012030; Mon, 19 Jul 2004 09:24:52 -0400 (EDT) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: Brian Fundakowski Feldman Date: Mon, 19 Jul 2004 09:25:56 -0400 User-Agent: KMail/1.6 References: <200407190621.i6J6LRWJ019976@repoman.freebsd.org> <20040719071147.GS18577@cs.rice.edu> <20040719103917.GD1038@green.homeunix.org> In-Reply-To: <20040719103917.GD1038@green.homeunix.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200407190925.56489.jhb@FreeBSD.org> X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx cc: cvs-src@FreeBSD.org cc: Scott Long cc: src-committers@FreeBSD.org cc: Alan Cox cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys malloc.h src/sys/kern kern_malloc.c src/sys/vm vm_contig.c vm_page.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Jul 2004 13:25:15 -0000 On Monday 19 July 2004 06:39 am, Brian Fundakowski Feldman wrote: > On Mon, Jul 19, 2004 at 02:11:47AM -0500, Alan Cox wrote: > > On Mon, Jul 19, 2004 at 01:00:27AM -0600, Scott Long wrote: > > > This is a pretty darn big change to something that is so vital to so > > > many drivers (not including busdma, which means that this touches > > > nearly every driver). Who reviewed this? Was it discussed on a public > > > mailing list? What kind of testing was done for it? If you can't > > > answer these questions then I'm not terribly thrilled. > > > > I reviewed an earlier version of this and gave Brian some feedback. > > > > It is important to note that he added the new implementation side-by-side > > with the old. By default, the old implementation is still used. So, I > > wouldn't be too concerned. > > Aye, I didn't feel totally comfortable saying "Reviewed by:" since that > was a while ago, but between alc and hmp who has been overhauling the > contigmalloc() implementation in DFBSD there wasn't any concern that I > know I hadn't addressed (and Dillon ignored my solicitation). For future reference: In this case I usually add a line along the lines of: Reviewed by: bde (an earlier version) Which is both truthful and avoids the ensuing flamewar due to the appearance of an unreviewed driveby. :) -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org