From owner-svn-src-all@FreeBSD.ORG Wed Jun 22 02:41:18 2011 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BC02310657C3; Wed, 22 Jun 2011 02:41:18 +0000 (UTC) (envelope-from alc@rice.edu) Received: from mh6.mail.rice.edu (mh6.mail.rice.edu [128.42.201.4]) by mx1.freebsd.org (Postfix) with ESMTP id 7DC2D8FC18; Wed, 22 Jun 2011 02:41:18 +0000 (UTC) Received: from mh6.mail.rice.edu (localhost.localdomain [127.0.0.1]) by mh6.mail.rice.edu (Postfix) with ESMTP id 98BC82904C1; Tue, 21 Jun 2011 21:41:17 -0500 (CDT) X-Virus-Scanned: by amavis-2.6.4 at mh6.mail.rice.edu, auth channel Received: from mh6.mail.rice.edu ([127.0.0.1]) by mh6.mail.rice.edu (mh6.mail.rice.edu [127.0.0.1]) (amavis, port 10026) with ESMTP id kwz8tdPEGGuM; Tue, 21 Jun 2011 21:41:17 -0500 (CDT) Received: from adsl-216-63-78-18.dsl.hstntx.swbell.net (adsl-216-63-78-18.dsl.hstntx.swbell.net [216.63.78.18]) (using TLSv1 with cipher RC4-MD5 (128/128 bits)) (No client certificate requested) (Authenticated sender: alc) by mh6.mail.rice.edu (Postfix) with ESMTPSA id 6232C2904A6; Tue, 21 Jun 2011 21:41:16 -0500 (CDT) Message-ID: <4E01564B.70507@rice.edu> Date: Tue, 21 Jun 2011 21:41:15 -0500 From: Alan Cox User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.9.2.15) Gecko/20110328 Thunderbird/3.1.9 MIME-Version: 1.0 To: Warner Losh References: <201106191913.p5JJDOqJ006272@svn.freebsd.org> <20110622063258.D2275@besplex.bde.org> <4E0128FF.6020804@rice.edu> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: src-committers@FreeBSD.org, Alan Cox , svn-src-all@FreeBSD.org, Attilio Rao , "Bjoern A. Zeeb" , Bruce Evans , svn-src-head@FreeBSD.org Subject: Re: svn commit: r223307 - head/sys/vm X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Jun 2011 02:41:18 -0000 On 06/21/2011 21:27, Warner Losh wrote: > > On Jun 21, 2011, at 5:27 PM, Alan Cox wrote: > >> On 06/21/2011 16:09, Attilio Rao wrote: >>> 2011/6/21 Bruce Evans>> >: >>>> On Tue, 21 Jun 2011, Bjoern A. Zeeb wrote: >>>> >>>>> On Jun 19, 2011, at 7:13 PM, Alan Cox wrote: >>>>> >>>>> Hi Alan, >>>>> >>>>>> Author: alc >>>>>> Date: Sun Jun 19 19:13:24 2011 >>>>>> New Revision: 223307 >>>>>> URL: http://svn.freebsd.org/changeset/base/223307 >>>>>> >>>>>> Log: >>>>>> Precisely document the synchronization rules for the page's >>>>>> dirty field. >>>>>> (Saying that the lock on the object that the page belongs to must be >>>>>> held >>>>>> only represents one aspect of the rules.) >>>>>> >>>>>> Eliminate the use of the page queues lock for atomically performing >>>>>> read- >>>>>> modify-write operations on the dirty field when the underlying >>>>>> architecture >>>>>> supports atomic operations on char and short types. >>>>>> >>>>>> Document the fact that 32KB pages aren't really supported. >>>>> contrary to the tinderbox I'd like to point out that all mips kernels >>>>> built by universe are broken with a SVN HEAD from earlier today. >>>>> Could you >>>>> please check and see if you can fix it? The errors I get are: >>>>> >>>>> vm_page.o: In function `vm_page_clear_dirty': >>>>> /sys/vm/vm_page.c:(.text+0x18d0): undefined reference to >>>>> `atomic_clear_8' >>>>> /sys/vm/vm_page.c:(.text+0x18d0): relocation truncated to fit: >>>>> R_MIPS_26 >>>>> against `atomic_clear_8' >>>>> vm_page.o: In function `vm_page_set_validclean': >>>>> /sys/vm/vm_page.c:(.text+0x38f0): undefined reference to >>>>> `atomic_clear_8' >>>>> /sys/vm/vm_page.c:(.text+0x38f0): relocation truncated to fit: >>>>> R_MIPS_26 >>>>> against `atomic_clear_8' >>>> Atomic types shorter than int cannot be used in MI code, since they >>>> might >>>> not exist. Apparently they don't exist on mips. jake@ fixed all their >>>> old uses for sparc4 in ~Y2K. >>> I'm sure they do, they exist in support.S though and may not have the >>> _8 form (they may just have the _char version). I may look at the code >>> again to be sure. >>> >> >> It appears that while mips/include/atomic.h declares the existence of >> atomic_clear_8, mips/mips/support.S doesn't implement it. In other >> words, only support for int's and short's is currently implemented, >> not char's: >> >> # grep atomic_clear mips/mips/support.S >> * atomic_clear_32(u_int32_t *a, u_int32_t b) >> LEAF(atomic_clear_32) >> END(atomic_clear_32) >> * atomic_clear_16(u_int16_t *a, u_int16_t b) >> LEAF(atomic_clear_16) >> END(atomic_clear_16) > > The current crop of atomic*16 and atomic*8 functions have the > restriction that the address must be 32-bit aligned (and it forces > this by aligning to 32-bits silently and then operates on the low 8 or > 16 bits in that word!) > > I'm guessing that this is likely just wrong. Comments? Yes, that would be wrong. Alan