From owner-freebsd-ports@FreeBSD.ORG Sun May 14 14:44:41 2006 Return-Path: X-Original-To: freebsd-ports@FreeBSD.org Delivered-To: freebsd-ports@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0CCD216A404; Sun, 14 May 2006 14:44:41 +0000 (UTC) (envelope-from pav@FreeBSD.org) Received: from hood.oook.cz (hood.oook.cz [195.250.137.134]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5B01D43D49; Sun, 14 May 2006 14:44:40 +0000 (GMT) (envelope-from pav@FreeBSD.org) Received: from ikaros.oook.cz (localhost [127.0.0.1]) by hood.oook.cz (8.13.6/8.13.6) with ESMTP id k4EEidU2002832 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 14 May 2006 16:44:39 +0200 (CEST) (envelope-from pav@FreeBSD.org) Received: (from pav@localhost) by ikaros.oook.cz (8.13.6/8.13.6/Submit) id k4EEidSc002831; Sun, 14 May 2006 16:44:39 +0200 (CEST) (envelope-from pav@FreeBSD.org) X-Authentication-Warning: ikaros.oook.cz: pav set sender to pav@FreeBSD.org using -f From: Pav Lucistnik To: Coleman Kane In-Reply-To: <20060512184424.GA57858@ramen.coleyandcheryl> References: <20060512184424.GA57858@ramen.coleyandcheryl> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-VWQqp1gDUL82fFpukpWP" Date: Sun, 14 May 2006 16:44:38 +0200 Message-Id: <1147617878.73451.17.camel@ikaros.oook.cz> Mime-Version: 1.0 X-Mailer: Evolution 2.6.1 FreeBSD GNOME Team Port Cc: FreeBSD Ports Subject: Re: RFC: Standardize and improve the PKGNAMESUFFIX handling in all ports X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pav@FreeBSD.org List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 May 2006 14:44:41 -0000 --=-VWQqp1gDUL82fFpukpWP Content-Type: text/plain; charset=ISO-8859-2 Content-Transfer-Encoding: quoted-printable Coleman Kane p=ED=B9e v p=E1 12. 05. 2006 v 18:44 +0000: > Hello all, >=20 > During some discussion, the existence of two problems in ports > arose today surrounding handling of PKGNAMESUFFIX in the ports collection= . >=20 > First of all, the ability for it to handle multiple suffixes is broken > in many ports, and not intuitive to accomplish, and the declaration of > such option is not standard. > Currently, if you have a port that has a toggle to reflect in the package > name, you use "packagename+toggle-versioninfo". In many ports, this is=20 > accomplished via: > PKGNAMESUFFIX=3D +toggle >=20 > If you want to add more than one toggle, you'd do: > PKGNAMESUFFIX:=3D"${PACKAGENAMESUFFIX}+toggle1" > ... > PKGNAMESUFFIX:=3D"${PACKAGENAMESUFFIX}+toggle2" >=20 > To get 'packagename+toggle1+toggle2-versioninfo'. >=20 > Unfortunately, this is not done in many ports (such as ruby18), and the > nomenclature swaps plus and hyphen for the 'toggle separator'. >=20 > I propose that we do this: > Add to line 1199 of ports/Mk/bsd.port.mk > _JOINEDPKGNAMESUFFIX?=3D > .for _PKGNAMESUFFIXCOMPONENT in ${PKGNAMESUFFIX:O:u} > _JOINEDPKGNAMESUFFIX:=3D"${_JOINEDPKGNAMESUFFIX}+${_PKGNAMESUFFIXCOMPON= ENT}" > .endfor >=20 > Change line 1207: > PKGNAME=3D ${PKGNAMEPREFIX}${PORTNAME}${_JOINEDPKGNAMESUFFIX}-${PORTVE= RSION:C/[-_,]/./g}${_SUF1}${_SUF2} >=20 > Change line 2620: > PKGBASE?=3D ${PKGNAMEPREFIX}${PORTNAME}${_JOINEDPKGNAMESUFFIX} >=20 > And then, rather than literally specifying the PKGNAMESUFFIX, you would d= o this: > PKGNAMESUFFIX+=3D toggle1 > ... > PKGNAMESUFFIX+=3D toggle2 >=20 > Which is far more intuitive and more readable. >=20 > And the addition at line 1199, specified above, would automagically add t= he > + delimiters, order the toggles alphabetically, and weed out the duplicat= es. >=20 > This could be one more step toward a more manageable package infrastructu= re. >=20 > As I said, this is an RFC so give me comments! Looks good. --=20 Pav Lucistnik 25 And the Lord spoke unto the Angel that guarded the eastern gate, saying, Where is the flaming sword which was given unto thee? 26 And the Angel said, I had here only a moment ago, I must have put it dow= n some where, forget my own head next. 27 And the Lord did not ask him again. --=-VWQqp1gDUL82fFpukpWP Content-Type: application/pgp-signature; name=signature.asc Content-Description: Toto je =?iso-8859-2?Q?digit=E1ln=EC?= =?ISO-8859-1?Q?_podepsan=E1?= =?iso-8859-2?Q?_=E8=E1st?= =?ISO-8859-1?Q?_zpr=E1vy?= -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (FreeBSD) iD8DBQBEZ0JWntdYP8FOsoIRAlsLAJ0epaEYnTCKuy2RI8MG2dbBgOZb2wCfQv2V VqqolWX5iDcRZv8DkWbM+8o= =Fdx7 -----END PGP SIGNATURE----- --=-VWQqp1gDUL82fFpukpWP--