From owner-freebsd-hackers@FreeBSD.ORG Tue Oct 19 13:55:59 2010 Return-Path: Delivered-To: freebsd-hackers@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 40BC0106564A for ; Tue, 19 Oct 2010 13:55:59 +0000 (UTC) (envelope-from mj@feral.com) Received: from ns1.feral.com (ns1.feral.com [192.67.166.1]) by mx1.freebsd.org (Postfix) with ESMTP id EBE788FC1A for ; Tue, 19 Oct 2010 13:55:58 +0000 (UTC) Received: from [192.168.1.2] (m206-63.dsl.tsoft.com [198.144.206.63]) by ns1.feral.com (8.14.3/8.14.3) with ESMTP id o9JDtvK7016830; Tue, 19 Oct 2010 06:55:58 -0700 (PDT) (envelope-from mj@feral.com) Message-ID: <4CBDA371.4080801@feral.com> Date: Tue, 19 Oct 2010 06:56:01 -0700 From: Matthew Jacob Organization: Feral Software User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.9) Gecko/20100915 Thunderbird/3.1.4 MIME-Version: 1.0 To: Alexander Best References: <20101018235318.GA87158@freebsd.org> <4CBCE67C.1070106@feral.com> <20101019103432.GA69208@freebsd.org> In-Reply-To: <20101019103432.GA69208@freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Default is to whitelist mail, not delayed by milter-greylist-4.2.6 (ns1.feral.com [192.67.166.1]); Tue, 19 Oct 2010 06:55:58 -0700 (PDT) Cc: freebsd-hackers@FreeBSD.ORG Subject: Re: SCSI_DELAY cleanup X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2010 13:55:59 -0000 It would be an effective behavioral change for those of us who remove that line. Personally, I think 5 seconds is too long- even 2 seconds is more than adequate even for moderately old 'other' hardware like scanners. For -current, why don't you simply remove all of the config lines and leave the default at 2000ms? On 10/19/2010 3:34 AM, Alexander Best wrote: > On Mon Oct 18 10, Matthew Jacob wrote: >> What problem are you solving by this change? > code cleanup. > > the scsi delay value currently defaults to 2000ms. however that doesn't make > sense, since on almost all platforms it gets set to 5000ms in the default > config. what's the purpose of having a default value, if it is much more often > overwritten than actually used? > > that's why this patch changes the default scsi delay value to 5000ms. now all > of the lines that were setting the scsi delay value to 5000ms can be removed. > also default values should be chosen very conservatively. users can always > lower the delay value via their kernel config or sysctl. > > cheers. > alex