From owner-cvs-all  Thu Oct 25  5: 9:32 2001
Delivered-To: cvs-all@freebsd.org
Received: from gw.nectar.com (gw.nectar.com [208.42.49.153])
	by hub.freebsd.org (Postfix) with ESMTP
	id 637D437B403; Thu, 25 Oct 2001 05:09:27 -0700 (PDT)
Received: from madman.nectar.com (madman.nectar.com [10.0.1.111])
	by gw.nectar.com (Postfix) with ESMTP
	id A5CE848; Thu, 25 Oct 2001 07:09:26 -0500 (CDT)
Received: (from nectar@localhost)
	by madman.nectar.com (8.11.6/8.11.3) id f9PC9Ql73139;
	Thu, 25 Oct 2001 07:09:26 -0500 (CDT)
	(envelope-from nectar)
Date: Thu, 25 Oct 2001 07:09:26 -0500
From: "Jacques A. Vidrine" <n@nectar.com>
To: Dirk Meyer <dinoex@FreeBSD.org>
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: ports/security/openssh Makefile ports/security/openssh/files patch-coredump ports/security/openssh-portable Makefile ports/security/openssh-portable/files patch-coredump
Message-ID: <20011025070926.A73086@madman.nectar.com>
Mail-Followup-To: "Jacques A. Vidrine" <n@nectar.com>,
	Dirk Meyer <dinoex@FreeBSD.org>, cvs-committers@FreeBSD.org,
	cvs-all@FreeBSD.org
References: <200110240716.f9O7GnQ17535@freefall.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <200110240716.f9O7GnQ17535@freefall.freebsd.org>; from dinoex@FreeBSD.org on Wed, Oct 24, 2001 at 12:16:49AM -0700
X-Url: http://www.nectar.com/
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Wed, Oct 24, 2001 at 12:16:49AM -0700, Dirk Meyer wrote:
> dinoex      2001/10/24 00:16:49 PDT
> 
>   Modified files:
>     security/openssh     Makefile 
>     security/openssh-portable Makefile 
>   Added files:
>     security/openssh/files patch-coredump 
>     security/openssh-portable/files patch-coredump 
>   Log:
>   - included an patch that solves a coredump in sshd
>   - Bumped PORTREVISION

Please do not use more than one  patch file per source file.  Now both
`patch-session.c' and `patch-coredump' modify `session.c'.

Also, do you  have more information on the problem  that is supposedly
solved by  this patch?   The patch simply  initializes `env'  to NULL.
However, `env'  is not used before  being initialized that I  can see.
Did I miss something?

  void
  do_child(Session *s, const char *command)
  {
          [... the patch makes this change ...]
-         char **env;
+         char **env = NULL;
          [... first reference to env follows ...]
          envsize = 100;
          env = xmalloc(envsize * sizeof(char *));

Cheers,
-- 
Jacques A. Vidrine <n@nectar.com>                   http://www.nectar.com/
Verio Web Hosting       =      FreeBSD UNIX      =        Heimdal Kerberos
jvidrine@verio.net      =   nectar@FreeBSD.org   =       nectar@pdc.kth.se

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message