From owner-freebsd-scsi@FreeBSD.ORG Fri May 16 15:17:15 2003 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CEFB937B401 for ; Fri, 16 May 2003 15:17:15 -0700 (PDT) Received: from rootlabs.com (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id 0347F43F85 for ; Fri, 16 May 2003 15:17:15 -0700 (PDT) (envelope-from nate@rootlabs.com) Received: (qmail 83301 invoked by uid 1000); 16 May 2003 22:17:16 -0000 Date: Fri, 16 May 2003 15:17:16 -0700 (PDT) From: Nate Lawson To: Scott Long In-Reply-To: <3EC53467.9080101@btc.adaptec.com> Message-ID: <20030516151546.S83293@root.org> References: <20030516105356.E82960@root.org> <3EC53467.9080101@btc.adaptec.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: scsi@freebsd.org Subject: Re: PATCH: merge calc geometry calls into convenience function X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 May 2003 22:17:16 -0000 On Fri, 16 May 2003, Scott Long wrote: > cam_calc_std_geometry() might be a better name. I like the idea in any > case. However, could you hold off until after the 5.1 branch? Of course. This was just something I had in my tree that I wanted to get out for review. It is not being considered for 5.1. I'd also like comments about the location of the function and prototype (in cam.c and cam_ccb.h). This is a minor thing but good since several bugs were uncovered in the previous cut/pasted functions. -Nate