From owner-svn-ports-head@freebsd.org  Tue Oct  6 16:59:10 2015
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id D1B549D0A5B;
 Tue,  6 Oct 2015 16:59:10 +0000 (UTC)
 (envelope-from amdmi3@amdmi3.ru)
Received: from vps.amdmi3.ru (vps.amdmi3.ru [109.234.38.216])
 by mx1.freebsd.org (Postfix) with ESMTP id 9B3E0A9D;
 Tue,  6 Oct 2015 16:59:10 +0000 (UTC)
 (envelope-from amdmi3@amdmi3.ru)
Received: from hive.panopticon (unknown [78.153.152.119])
 by vps.amdmi3.ru (Postfix) with ESMTPS id EA839B061F;
 Tue,  6 Oct 2015 19:59:09 +0300 (MSK)
Received: from hades.panopticon (hades.panopticon [192.168.0.32])
 by hive.panopticon (Postfix) with ESMTP id 15F02C77;
 Tue,  6 Oct 2015 19:55:26 +0300 (MSK)
Received: by hades.panopticon (Postfix, from userid 1000)
 id E3D0BD6; Tue,  6 Oct 2015 19:58:08 +0300 (MSK)
Date: Tue, 6 Oct 2015 19:58:08 +0300
From: Dmitry Marakasov <amdmi3@amdmi3.ru>
To: Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r398474 - head/Mk/Uses
Message-ID: <20151006165808.GC68979@hades.panopticon>
References: <201510031706.t93H6qiu007585@repo.freebsd.org>
 <20151006165135.GB68979@hades.panopticon>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20151006165135.GB68979@hades.panopticon>
User-Agent: Mutt/1.5.24 (2015-08-30)
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Oct 2015 16:59:10 -0000

* Dmitry Marakasov (amdmi3@hades.panopticon) wrote:
> * Sunpoet Po-Chuan Hsieh (sunpoet@FreeBSD.org) wrote:
> 
> > Log:
> >   - Add NO_PERL5_TEST: allow ports with USES=perl5 to run default do-test: defined in bsd.port.mk
> >   - Fix comment
> > 
> > Modified:
> >   head/Mk/Uses/perl5.mk
> > 
> > Modified: head/Mk/Uses/perl5.mk
> > ==============================================================================
> > --- head/Mk/Uses/perl5.mk	Sat Oct  3 16:30:19 2015	(r398473)
> > +++ head/Mk/Uses/perl5.mk	Sat Oct  3 17:06:52 2015	(r398474)
> > @@ -308,7 +308,7 @@ fix-perl-things:
> >  	@${RM} -f ${STAGEDIR}${PREFIX}/lib/perl5/${PERL_VER}/${PERL_ARCH}/perllocal.pod* || :
> >  	@${RMDIR} -p ${STAGEDIR}${PREFIX}/lib/perl5/${PERL_VER}/${PERL_ARCH} 2>/dev/null || :
> >  
> > -.if !target(do-test)
> > +.if !target(do-test) && !defined(NO_PERL5_TEST)
> >  TEST_TARGET?=	test
> >  TEST_WRKSRC?=	${BUILD_WRKSRC}
> >  do-test:
> > @@ -317,5 +317,5 @@ do-test:
> >  .elif ${USE_PERL5:Mconfigure}
> >  	cd ${TEST_WRKSRC}/ && ${SETENV} ${TEST_ENV} ${MAKE_CMD} ${TEST_ARGS} ${TEST_TARGET}
> >  .endif # USE_PERL5:Mmodbuild*
> > -.endif # regression-test
> > +.endif # do-test
> >  .endif # defined(_POSTMKINCLUDED)
> 
> Please roll this back. We already have NO_TEST specifically for this
> purpose. Also, I'd be really grateful if tests-related infrastructure
> changes are reviewed first with me CCd.

However it looks like it needs check for ${USE_PERL5:Mconfigure} || ${USE_PERL5:Mmodbuild*}

-- 
Dmitry Marakasov   .   55B5 0596 FF1E 8D84 5F56  9510 D35A 80DD F9D2 F77D
amdmi3@amdmi3.ru  ..:  jabber: amdmi3@jabber.ru      http://amdmi3.ru