From owner-freebsd-bugs@FreeBSD.ORG Thu Sep 27 09:40:08 2012 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AB300106566C for ; Thu, 27 Sep 2012 09:40:08 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 6B7708FC15 for ; Thu, 27 Sep 2012 09:40:08 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q8R9e8Lv019584 for ; Thu, 27 Sep 2012 09:40:08 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q8R9e8pG019578; Thu, 27 Sep 2012 09:40:08 GMT (envelope-from gnats) Resent-Date: Thu, 27 Sep 2012 09:40:08 GMT Resent-Message-Id: <201209270940.q8R9e8pG019578@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, "Ilya A. Arkhipov" Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8117F106566C for ; Thu, 27 Sep 2012 09:39:16 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id 6D4228FC0A for ; Thu, 27 Sep 2012 09:39:16 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.5/8.14.5) with ESMTP id q8R9dFoO032672 for ; Thu, 27 Sep 2012 09:39:15 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.5/8.14.5/Submit) id q8R9dFgx032670; Thu, 27 Sep 2012 09:39:15 GMT (envelope-from nobody) Message-Id: <201209270939.q8R9dFgx032670@red.freebsd.org> Date: Thu, 27 Sep 2012 09:39:15 GMT From: "Ilya A. Arkhipov" To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: bin/172112: [patch] Fix for incorrect work: pw user show 0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Sep 2012 09:40:08 -0000 >Number: 172112 >Category: bin >Synopsis: [patch] Fix for incorrect work: pw user show 0 >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Thu Sep 27 09:40:08 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Ilya A. Arkhipov >Release: CURRENT >Organization: Luxoft >Environment: FreeBSD gdpsolaris 10.0-CURRENT FreeBSD 10.0-CURRENT #0: Mon Sep 17 08:52:10 UTC 2012 root@gdpsolaris:/usr/obj/usr/src/sys/GENERIC amd64 >Description: pw incorrect works with 0 uid: # pw user show 0 pw: no such user `0' Yes I know regarding -u, but: # pw user show 80 www:*:80:80::0:0:World Wide Web Owner:/nonexistent:/usr/sbin/nologin we just need fix pw_user.c#318 ">" to ">=" >How-To-Repeat: pw user show 0 >Fix: --- pw_user.c_old 2012-09-27 12:22:27.043408321 +0000 +++ pw_user.c 2012-09-27 11:54:19.386410444 +0000 @@ -315,7 +315,7 @@ */ if (mode != M_ADD && pwd == NULL && strspn(a_name->val, "0123456789") == strlen(a_name->val) - && atoi(a_name->val) > 0) { /* Assume uid */ + && atoi(a_name->val) >= 0) { /* Assume uid */ (a_uid = a_name)->ch = 'u'; a_name = NULL; } Patch attached with submission follows: --- pw_user.c_old 2012-09-27 12:22:27.043408321 +0000 +++ pw_user.c 2012-09-27 11:54:19.386410444 +0000 @@ -315,7 +315,7 @@ */ if (mode != M_ADD && pwd == NULL && strspn(a_name->val, "0123456789") == strlen(a_name->val) - && atoi(a_name->val) > 0) { /* Assume uid */ + && atoi(a_name->val) >= 0) { /* Assume uid */ (a_uid = a_name)->ch = 'u'; a_name = NULL; } >Release-Note: >Audit-Trail: >Unformatted: