From owner-freebsd-current@FreeBSD.ORG  Sat Jan 14 15:16:22 2012
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5B92A106566B
	for <freebsd-current@FreeBSD.org>; Sat, 14 Jan 2012 15:16:22 +0000 (UTC)
	(envelope-from rhurlin@gwdg.de)
Received: from fmailer.gwdg.de (fmailer.gwdg.de [134.76.11.16])
	by mx1.freebsd.org (Postfix) with ESMTP id 1978E8FC15
	for <freebsd-current@FreeBSD.org>; Sat, 14 Jan 2012 15:16:21 +0000 (UTC)
Received: from pd951dbfd.dip.t-dialin.net ([217.81.219.253]
	helo=krabat.raven.hur)
	by mailer.gwdg.de with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.72)
	(envelope-from <rhurlin@gwdg.de>)
	id 1Rm5LA-00054Y-Co; Sat, 14 Jan 2012 16:16:20 +0100
Message-ID: <4F119C40.2080503@gwdg.de>
Date: Sat, 14 Jan 2012 16:16:16 +0100
From: Rainer Hurling <rhurlin@gwdg.de>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
	rv:9.0) Gecko/20111222 Thunderbird/9.0
MIME-Version: 1.0
To: Doug Barton <dougb@FreeBSD.org>
References: <4F114577.30201@FreeBSD.org>
In-Reply-To: <4F114577.30201@FreeBSD.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Authenticated: Id:rhurlin
X-Spam-Level: -
X-Virus-Scanned: (clean) by exiscan+sophie
Cc: freebsd-current <freebsd-current@FreeBSD.org>
Subject: Re: HEADS UP: set_rcvar() removed from rc.subr
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 14 Jan 2012 15:16:22 -0000

On 14.01.2012 10:05 (UTC+1), Doug Barton wrote:
> Howdy,
>
> Per discussion in freebsd-rc@, I have removed set_rcvar() from rc.subr.
> The concept of set_rcvar() was nice in theory, but the forks it creates
> are a drag on the startup process, which is especially noticeable on
> slower systems, such as embedded ones.
>
> I have no plans to MFC this change, so it should only affect users who
> are actually on 10-current. If you have scripts in /usr/local/etc/rc.d
> (which if you have ports installed you almost certainly do) ...
>
> to make the change by hand, change this:
>
> name=foo
> rcvar=`set_rcvar`
>
> to:
>
> name=foo
> rcvar=foo_enable
>
> I didn't bump PORTREVISIONs because the change only applies to HEAD. But
> all of the ports are updated, so if you can't figure out how to make the
> change, just reinstall it.
>
>
> Doug

Seems that ports-mgmt/tinderbox needs an update like this:

files/patch-etc__rc.d__tinderd

--- etc/rc.d/tinderd.orig       2011-11-20 07:01:09.000000000 +0100
+++ etc/rc.d/tinderd    2012-01-14 16:07:38.000000000 +0100
@@ -16,7 +16,7 @@
  . /etc/rc.subr

  name="tinderd"
-rcvar=`set_rcvar`
+rcvar=tinderd_enable

  # read settings, set default values
  load_rc_config "${name}"


Have not checked tinderbox-devel.

BTW, is there any reason not to set 'rcvar=${name}_enable' in all that 
cases?

Rainer Hurling