From owner-freebsd-smp Wed Aug 22 23:37:28 2001 Delivered-To: freebsd-smp@freebsd.org Received: from earth.backplane.com (earth-nat-cw.backplane.com [208.161.114.67]) by hub.freebsd.org (Postfix) with ESMTP id 0F20537B40A; Wed, 22 Aug 2001 23:37:22 -0700 (PDT) (envelope-from dillon@earth.backplane.com) Received: (from dillon@localhost) by earth.backplane.com (8.11.4/8.11.2) id f7N6bKs83608; Wed, 22 Aug 2001 23:37:20 -0700 (PDT) (envelope-from dillon) Date: Wed, 22 Aug 2001 23:37:20 -0700 (PDT) From: Matt Dillon Message-Id: <200108230637.f7N6bKs83608@earth.backplane.com> To: Terry Lambert Cc: Jake Burkholder , John Baldwin , freebsd-smp@FreeBSD.ORG, freebsd-alpha@FreeBSD.ORG Subject: Re: Preliminary proposed rollup of kernel submap initialization code References: <200108210157.f7L1vAh10384@k7.locore.ca> <200108211736.f7LHaoC64628@earth.backplane.com> <3B83623D.9DC45B93@mindspring.com> <200108221456.f7MEufD74609@earth.backplane.com> <3B84A08D.92864A27@mindspring.com> Sender: owner-freebsd-smp@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org : :Matt Dillon wrote: :> I don't follow. The argument passing and pointer arithmatic is not :> expensive at all - in fact, it is less expensive then the original MD :> code if you look at the assembly output! And who really gives a damn :> about a few nanoseconds during boot anyway? : :I was just thinking that, wherever possible, the reference should :supply easy to understand C code that can be replaced by platform :specific assembly versions, when necessary. The issue with the :pointer pass is that it'll be a bit harder to code an assembly :.. You lost me. This is one-time single-execution code. Unless you are planning on rewriting the entire FreeBSD OS in assembly there is no issue. :Uh, I complained that the declaration was _NOT_ static... that's :what made the pointer reference to it so curious: it was already :available as a global, so it didn't make sense why you were passing :its address around, and then doing pointer math on it, instead of :just referencing the elements directly. This isn't designed for general use. It's because there are two different source files in i386/i386 (blah/blah) that access the structure. Otherwise I would have happily made it static. I'm sure the extern is in the wrong place, but I believe Bruce is planning on fixing that. -Matt To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-smp" in the body of the message