From owner-freebsd-current@FreeBSD.ORG Fri Jun 17 08:35:09 2005 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F249E16A41C for ; Fri, 17 Jun 2005 08:35:09 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id C3B8043D1F for ; Fri, 17 Jun 2005 08:35:09 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (obrien@localhost [127.0.0.1]) by dragon.NUXI.org (8.13.4/8.13.4) with ESMTP id j5H8Z9o6003362; Fri, 17 Jun 2005 01:35:09 -0700 (PDT) (envelope-from obrien@dragon.NUXI.org) Received: (from obrien@localhost) by dragon.NUXI.org (8.13.4/8.13.1/Submit) id j5H8Z8t6003361; Fri, 17 Jun 2005 01:35:08 -0700 (PDT) (envelope-from obrien) Date: Fri, 17 Jun 2005 01:35:08 -0700 From: "David O'Brien" To: Ed Maste Message-ID: <20050617083507.GA3061@dragon.NUXI.org> Mail-Followup-To: obrien@freebsd.org, Ed Maste , freebsd-current@freebsd.org, Doug White References: <20050613192308.GA87640@sandvine.com> <20050614082039.GA2038@dragon.NUXI.org> <20050614224704.Y75797@mp2.macomnet.net> <20050614190854.GA12928@dragon.NUXI.org> <20050614235132.L76669@mp2.macomnet.net> <20050615023600.GA20721@dragon.NUXI.org> <20050615141447.GD95217@sandvine.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050615141447.GD95217@sandvine.com> X-Operating-System: FreeBSD 6.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 User-Agent: Mutt/1.5.9i Cc: freebsd-current@freebsd.org Subject: Re: savecore(8) increments /var/crash/bounds on each boot X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@freebsd.org List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Jun 2005 08:35:10 -0000 On Wed, Jun 15, 2005 at 10:14:47AM -0400, Ed Maste wrote: > On Tue, Jun 14, 2005 at 07:36:00PM -0700, David O'Brien wrote: > > Do you understand the fix? How does lying in printheader() fix anything? > > Moving the call to getbounds() back to the original location is the "fix" > > but then it negates -vv. We shouldn't lie in printheader(). > > Fair enough, on dwhite's suggestion here's another try that splits the > increment-and-write out from getbounds() so that the bounds value can > be shown with -vv. ..snip.. > --- savecore.c.orig 2005-06-13 16:19:41.000000000 -0400 > +++ savecore.c 2005-06-15 09:41:52.000000000 -0400 ... > + writebounds(bounds+1); ^^^^^^^^ bounds + 1 I like the patch, after the style(9) fix. Might as well avoid a brucification. ;-) Who's going to commit this patch? -- -- David (obrien@FreeBSD.org)