From owner-freebsd-doc@FreeBSD.ORG  Fri Dec 21 17:00:05 2007
Return-Path: <owner-freebsd-doc@FreeBSD.ORG>
Delivered-To: freebsd-doc@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7159516A46E
	for <freebsd-doc@hub.freebsd.org>; Fri, 21 Dec 2007 17:00:05 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 4DAC413C4EC
	for <freebsd-doc@hub.freebsd.org>; Fri, 21 Dec 2007 17:00:05 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id lBLH05Qf030812
	for <freebsd-doc@freefall.freebsd.org>; Fri, 21 Dec 2007 17:00:05 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.2/8.14.1/Submit) id lBLH05hR030811;
	Fri, 21 Dec 2007 17:00:05 GMT (envelope-from gnats)
Date: Fri, 21 Dec 2007 17:00:05 GMT
Message-Id: <200712211700.lBLH05hR030811@freefall.freebsd.org>
To: freebsd-doc@FreeBSD.org
From: Pietro Cerutti <gahr@gahr.ch>
Cc: 
Subject: Re: bin/118902: wrong signatures in d2i_RSAPublicKey man pages
X-BeenThere: freebsd-doc@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Pietro Cerutti <gahr@gahr.ch>
List-Id: Documentation project <freebsd-doc.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-doc>,
	<mailto:freebsd-doc-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-doc>
List-Post: <mailto:freebsd-doc@freebsd.org>
List-Help: <mailto:freebsd-doc-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-doc>,
	<mailto:freebsd-doc-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Dec 2007 17:00:05 -0000

The following reply was made to PR docs/118902; it has been noted by GNATS.

From: Pietro Cerutti <gahr@gahr.ch>
To: "Simon L. Nielsen" <simon@nitro.dk>
Cc: FreeBSD gnats submit <FreeBSD-gnats-submit@FreeBSD.org>
Subject: Re: bin/118902: wrong signatures in d2i_RSAPublicKey man pages
Date: Fri, 21 Dec 2007 17:52:53 +0100

 Simon L. Nielsen wrote:
 > On 2007.12.20 21:30:34 +0100, Pietro Cerutti wrote:
 > 
 >> the signatures for the following functions:
 >>
 >>  d2i_RSAPublicKey
 >>  d2i_RSA_PUBKEY
 >>  d2i_RSAPrivateKey
 >>  d2i_Netscape_RSA
 >>
 >> are wrong in our man pages.
 > 
 > [...]
 > 
 > The manual pages are actually generated from the upstream POD
 > documentation (openssl/doc/crypto/d2i_RSAPublicKey.pod) so the changes
 > need to be made to the POD files.  Otherwise they will simply vanish
 > after next import.
 
 Please look at [2] for a patch to the POD file.
 > 
 > Any chance you could submit the changes directly to the OpenSSL
 > project [1]?  Then we would get the fixes when the next version of
 > OpenSSL is imported.
 
 I've already CC'ed openssl-dev on the original PR submit.
 I will fill a bug report on their Request Tracker.
 
 > 
 > Does the source changes fix actual bugs or is it just style/warning?
 > If they don't fix real bugs I would prefer for them also to go via
 > OpenSSL to not divert from upstream more than needed.
 
 The last one in the .diff file adds const'ness to a variable
 declaration, which I find quite important.
 The other ones simply remove useless casts.
 
 [2] http://www.gahr.ch/FreeBSD/patches/118902_d2i_RSAPublicKey.pod.diff
 
 -- 
 Pietro Cerutti
 
 PGP Public Key:
 http://gahr.ch/pgp