From owner-freebsd-bugs@FreeBSD.ORG  Wed Apr 18 17:20:05 2012
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 229FE1065670
	for <freebsd-bugs@hub.freebsd.org>;
	Wed, 18 Apr 2012 17:20:05 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id D44EE8FC1A
	for <freebsd-bugs@hub.freebsd.org>;
	Wed, 18 Apr 2012 17:20:04 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q3IHK49V058097
	for <freebsd-bugs@freefall.freebsd.org>; Wed, 18 Apr 2012 17:20:04 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q3IHK4K3058096;
	Wed, 18 Apr 2012 17:20:04 GMT (envelope-from gnats)
Resent-Date: Wed, 18 Apr 2012 17:20:04 GMT
Resent-Message-Id: <201204181720.q3IHK4K3058096@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	Brian Jones <bjones@alacritech.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id BD755106566C
	for <freebsd-gnats-submit@FreeBSD.org>;
	Wed, 18 Apr 2012 17:13:27 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id A9ED58FC0A
	for <freebsd-gnats-submit@FreeBSD.org>;
	Wed, 18 Apr 2012 17:13:27 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q3IHDRll011923
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 18 Apr 2012 17:13:27 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id q3IHDRIS011917;
	Wed, 18 Apr 2012 17:13:27 GMT (envelope-from nobody)
Message-Id: <201204181713.q3IHDRIS011917@red.freebsd.org>
Date: Wed, 18 Apr 2012 17:13:27 GMT
From: Brian Jones <bjones@alacritech.com>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-3.1
Cc: 
Subject: misc/167068: memory leak in authunix_create_default()
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 18 Apr 2012 17:20:05 -0000


>Number:         167068
>Category:       misc
>Synopsis:       memory leak in authunix_create_default()
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Apr 18 17:20:04 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     Brian Jones
>Release:        8.0, 8.2, 9.0
>Organization:
Alacritech, Inc
>Environment:
FreeBSD nameserver.alacritech.com 8.0-RELEASE FreeBSD 8.0-RELEASE #0: Sat Nov 21 15:02:08 UTC 2009     root@mason.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  amd64

>Description:
In src/lib/libc/rpc/auth_unix.c:authunix_create_default(), gids is never freed.


>How-To-Repeat:
compile and run this test program:  Monitor RSS with ps.

----PGM_START----
#include <stdio.h>
#include <rpc/rpc.h>

main()
{
  AUTH            *auth;
  for(;;) {
     auth = authunix_create_default();
     auth_destroy(auth);
  }
  return(0);
}
----PGM_END----
>Fix:
diff 8.0/src/lib/libc/rpc/auth_unix.c local/src/lib/libc/rpc/auth_unix.c 
193a194
>       AUTH *au;
210,211c211,214
<       return (authunix_create(machname, (int)uid, (int)gid, ngids,
<           (int *)gids));
---
>       au = authunix_create(machname, (int)uid, (int)gid, ngids,
>           (int *)gids);
>       free(gids);
>       return au;

>Release-Note:
>Audit-Trail:
>Unformatted: