From owner-svn-ports-head@FreeBSD.ORG Mon Jan 27 11:19:13 2014 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 23A5BD00; Mon, 27 Jan 2014 11:19:13 +0000 (UTC) Received: from mail-we0-x233.google.com (mail-we0-x233.google.com [IPv6:2a00:1450:400c:c03::233]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 3CF971DC9; Mon, 27 Jan 2014 11:19:12 +0000 (UTC) Received: by mail-we0-f179.google.com with SMTP id w62so5157153wes.10 for ; Mon, 27 Jan 2014 03:19:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=M/m5IjcAjnJnyxu6h5mr3aa/ubY0cN7pB11JfEA29Rk=; b=Y5qli+eRV9MohytkQNPVn4M5bMga1cytaZ+QZzEWB3PwIxtHOdxU2FGUlvrpN+RzMJ PTgm/yA0jFGJn8z1rsyA2ZnX7XqP7uTi5rVUasvWBX0Cwqv1RKBMekBshHpFSfAAF5Yb g6Mz1s1Fxq2BCKNU1HD9gCBJfWLFIH6JeZS7d5HQoSFKEKv1B07202W2Qs7J5/Wdb6SE lbQAjpydhPuZI5cmcRdAZnPMjZAsFKSOW/8DrPa/FEDABSL9CKqf5VleAHpXcp0EERFF MjIp8Th0SEeHcXfByiOtUFhxIsO+dd/gp6if9CIkI8Tg3EIW0D8cFMXfWbePDy9Q53vU upfg== X-Received: by 10.180.160.206 with SMTP id xm14mr300348wib.25.1390821550593; Mon, 27 Jan 2014 03:19:10 -0800 (PST) Received: from ithaqua.etoilebsd.net (ithaqua.etoilebsd.net. [37.59.37.188]) by mx.google.com with ESMTPSA id di9sm27048327wid.6.2014.01.27.03.19.09 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 27 Jan 2014 03:19:09 -0800 (PST) Sender: Baptiste Daroussin Date: Mon, 27 Jan 2014 12:19:07 +0100 From: Baptiste Daroussin To: Alexey Dokuchaev Subject: Re: svn commit: r341341 - head/devel/xwpe Message-ID: <20140127111907.GE30300@ithaqua.etoilebsd.net> References: <201401270841.s0R8fjq3007225@svn.freebsd.org> <20140127092855.GA88072@FreeBSD.org> <20140127102231.GD30300@ithaqua.etoilebsd.net> <20140127103654.GA12714@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Qz2CZ664xQdCRdPu" Content-Disposition: inline In-Reply-To: <20140127103654.GA12714@FreeBSD.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jan 2014 11:19:13 -0000 --Qz2CZ664xQdCRdPu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 27, 2014 at 10:36:54AM +0000, Alexey Dokuchaev wrote: > On Mon, Jan 27, 2014 at 11:22:31AM +0100, Baptiste Daroussin wrote: > > This particular port is a bit special as the DESTDIR variable is already > > defined it but for something totally different, thus I decided to injec= t a > > variable named STAGEDIR instead that is why I defined DESTDIRNAME to > > STAGEDIR in the makefile. >=20 > OK, fair enough. :) Thanks for replying back. >=20 > > Your remark is valid is still valid for ports doing > > --prefix=3D${STAGEDIR}${PREFIX} which is often wrong but not for those = doing > > --prefix=3D\$${STAGEDIR}${PREFIX} :) >=20 > I've just checked StageDir wiki page again; it seems that it already > contains instructions on how to verify that STAGEDIR does not sneak inside > the binaries (via bzgrep vs. my own handcrafted strings-based approach). grep will say the binary matches, but sure it can be improved :) regards, Bapt --Qz2CZ664xQdCRdPu Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (FreeBSD) iEYEARECAAYFAlLmQKsACgkQ8kTtMUmk6EyD1ACeL8eUHqCEeBhfKTqnwEIqyPjr nNkAn3L2uGCziR0zPyJYxL8FSGOCNBhX =bpq3 -----END PGP SIGNATURE----- --Qz2CZ664xQdCRdPu--