From owner-cvs-all Tue Feb 4 18: 5:39 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AC21937B401; Tue, 4 Feb 2003 18:05:36 -0800 (PST) Received: from HAL9000.homeunix.com (12-233-57-224.client.attbi.com [12.233.57.224]) by mx1.FreeBSD.org (Postfix) with ESMTP id C837543FA3; Tue, 4 Feb 2003 18:05:35 -0800 (PST) (envelope-from dschultz@uclink.Berkeley.EDU) Received: from HAL9000.homeunix.com (localhost [127.0.0.1]) by HAL9000.homeunix.com (8.12.6/8.12.5) with ESMTP id h1525Y7m001751; Tue, 4 Feb 2003 18:05:34 -0800 (PST) (envelope-from dschultz@uclink.Berkeley.EDU) Received: (from das@localhost) by HAL9000.homeunix.com (8.12.6/8.12.5/Submit) id h1525YnA001750; Tue, 4 Feb 2003 18:05:34 -0800 (PST) (envelope-from dschultz@uclink.Berkeley.EDU) Date: Tue, 4 Feb 2003 18:05:34 -0800 From: David Schultz To: Scott Long Cc: Hajimu UMEMOTO , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/alpha/linux linux.h src/sys/compat/linux linux_socket.c src/sys/i386/linux linux.h src/sys/modules/linux Makefile Message-ID: <20030205020534.GA1354@HAL9000.homeunix.com> Mail-Followup-To: Scott Long , Hajimu UMEMOTO , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <200302031743.h13HhKSI085787@repoman.freebsd.org> <3E401B44.3080801@btc.adaptec.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3E401B44.3080801@btc.adaptec.com> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Thus spake Scott Long : > Hajimu UMEMOTO wrote: > > >ume 2003/02/03 09:43:20 PST > > > > Modified files: > > sys/alpha/linux linux.h > > sys/compat/linux linux_socket.c > > sys/i386/linux linux.h > > sys/modules/linux Makefile > > Log: > > Add IPv6 support for Linuxlator. > > > > Reviewed by: dwmalone > > MFC after: 10 days > > > > Revision Changes Path > > 1.57 +1 -0 src/sys/alpha/linux/linux.h > > 1.35 +372 -88 src/sys/compat/linux/linux_socket.c > > 1.61 +1 -0 src/sys/i386/linux/linux.h > > 1.61 +5 -2 src/sys/modules/linux/Makefile > > > The change to src/sys/modules/linux/Makefile unfortunately has a side > effect of make INET6 mandatory in the kernel in you want to load this as > a module. It's a tough problem to solve, I guess, since modules builds > are completely decoupled from kernel config files. Any ideas? FYI, the Linuxolator depends on COMPAT_43 for the same reasons. The easiest fix in this case is to unconditionalize the roughly five dozen lines of code. This adds a little bit of bloat in the !COMPAT_43 case, but it's a hell of a lot better than forcing all of the COMPAT_43 crud on everyone. A better solution to both of these problems, perhaps, would be to put all of the dependencies in one or more modules. This could certainly be done with the 4.3 socket compat layer required by the Linuxolator, and maybe with IPv6 as well. If that's too hard to do with IPv6, perhaps it could be arranged so that if the required symbols are not available, a stub module is loaded that always returns ENOSYS. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message