From owner-cvs-all@FreeBSD.ORG Mon Dec 13 17:37:12 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E787916A4CE; Mon, 13 Dec 2004 17:37:12 +0000 (GMT) Received: from electra.cse.Buffalo.EDU (electra.cse.Buffalo.EDU [128.205.32.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7900943D46; Mon, 13 Dec 2004 17:37:12 +0000 (GMT) (envelope-from kensmith@cse.Buffalo.EDU) Received: from electra.cse.Buffalo.EDU (kensmith@localhost [127.0.0.1]) iBDHb5Io004827; Mon, 13 Dec 2004 12:37:05 -0500 (EST) Received: (from kensmith@localhost) by electra.cse.Buffalo.EDU (8.12.10/8.12.9/Submit) id iBDHb5ph004826; Mon, 13 Dec 2004 12:37:05 -0500 (EST) Date: Mon, 13 Dec 2004 12:37:05 -0500 From: Ken Smith To: Warner Losh Message-ID: <20041213173705.GH1528@electra.cse.Buffalo.EDU> References: <20041213160418.GB1528@electra.cse.Buffalo.EDU> <20041213.091049.19644100.imp@bsdimp.com> <20041213.101932.41697633.imp@harmony.village.org> Mime-Version: 1.0 Content-Type: text/plain; charset=unknown-8bit Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20041213.101932.41697633.imp@harmony.village.org> User-Agent: Mutt/1.4.1i X-Mailman-Approved-At: Tue, 14 Dec 2004 12:39:15 +0000 cc: brooks@freebsd.org cc: brooks@one-eyed-alien.net cc: cvs-src@freebsd.org cc: cvs-all@freebsd.org cc: src-committers@freebsd.org cc: wb@freebie.xs4all.nl cc: des@des.no cc: kensmith@cse.Buffalo.EDU cc: imp@bsdimp.com Subject: Re: cvs commit: src/sbin/ifconfig ifconfig.c src/sys/net if.c if.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Dec 2004 17:37:13 -0000 On Mon, Dec 13, 2004 at 10:19:32AM -0700, Warner Losh wrote: > From: des@des.no (Dag-Erling Smørgrav) > Subject: Re: cvs commit: src/sbin/ifconfig ifconfig.c src/sys/net if.c if.h > Date: Mon, 13 Dec 2004 17:50:01 +0100 > > > "M. Warner Losh" writes: > > > Ken Smith writes: > > > > int main(void) > > > int main(int argc, char *argv[]) > > > > Both are correct according to the standard. > > The latter is what style(9) implies is the right one for FreeBSD. > Ok, two revisions (and at least two pointy hats) later, modulo above comment about what style(9) suggests (this is just a quick little test program so since we've got no intention of using the command line arguments one could argue less typing is better :-) we have this. Thanks to a few other people who have contributed substantially off-list. :-) #include #include #include #include #include #include "if.h" int main(void) { printf("sizeof if_data %zd\n", sizeof(struct if_data)); printf("offset ifi_mtu %zd\n", offsetof(struct if_data, ifi_mtu)); } -- Ken Smith - From there to here, from here to | kensmith@cse.buffalo.edu there, funny things are everywhere. | - Theodore Geisel |