From owner-cvs-all@FreeBSD.ORG Wed Mar 15 19:04:04 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 883B816A425; Wed, 15 Mar 2006 19:04:04 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id 01E3543D55; Wed, 15 Mar 2006 19:04:03 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id 8991246BE6; Wed, 15 Mar 2006 14:03:38 -0500 (EST) Date: Wed, 15 Mar 2006 19:04:57 +0000 (GMT) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Pawel Jakub Dawidek In-Reply-To: <20060315185909.GA16188@garage.freebsd.pl> Message-ID: <20060315190416.V36621@fledge.watson.org> References: <200603151230.k2FCU6sH042768@repoman.freebsd.org> <20060315185909.GA16188@garage.freebsd.pl> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys socketvar.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Mar 2006 19:04:04 -0000 On Wed, 15 Mar 2006, Pawel Jakub Dawidek wrote: > +> Add SS_PROTOREF socket flag, which represents a strong reference by the > +> protocol to the socket. Normally protocol references are weak: that is, > +> the socket layer can tear down the socket (and hence protocol state) > +> when it finds convenient. This flag will allow the protocol to > +> explicitly declare to the socket layer that it is maintaining a > +> strong reference, rather than the current implicit model associated > +> with so_pcb pointer values and repeated attempts to possibly free the > +> socket. > [...] > +> @@ -208,6 +208,7 @@ extern struct mtx accept_mtx; > +> #define SS_ASYNC 0x0200 /* async i/o notify */ > +> #define SS_ISCONFIRMING 0x0400 /* deciding to accept connection req */ > +> #define SS_ISDISCONNECTED 0x2000 /* socket disconnected from peer */ > +> +#define SS_PROTOREF 0x400 /* strong protocol reference */ > > You probably wanted 0x4000 here, no 0x400 which is already defined as > SS_ISCONFIRMING. Indeed. I decided to hand type the change instead of cutting down the current sockref patch to one chunk, and obviously that was a bad idea. Thanks! Robert N M Watson