From owner-svn-src-all@freebsd.org Tue Aug 16 14:57:07 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 77290BBCFF5 for ; Tue, 16 Aug 2016 14:57:07 +0000 (UTC) (envelope-from ed@nuxi.nl) Received: from mail-yb0-x22b.google.com (mail-yb0-x22b.google.com [IPv6:2607:f8b0:4002:c09::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 40A4E11B5 for ; Tue, 16 Aug 2016 14:57:07 +0000 (UTC) (envelope-from ed@nuxi.nl) Received: by mail-yb0-x22b.google.com with SMTP id d10so24831919ybi.1 for ; Tue, 16 Aug 2016 07:57:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuxi-nl.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=tqkcaX36QYOEALx41ugFpCOJXFRmtYPFxqx0EfjoXXE=; b=goj0qIBqhPItcjZ9rlGoKAR0tMc1mUMfBvdlW05AC6IZpRsox7tzROLT4WsYKUA+WX btPUNjQeh0vZtlTssQeePnwrJSpUOjdpLsVFXoX/Mz9q9HzKpv/5KjSnJJn1whpVN25r 3Q9qvCvY15aG9/c8eYzqLqfnHdEHJvdHXbF36pzgxofrdkXQ9tqJcT6E+wXHGZQTRryL mzA3Ee3Livt5VNFYMCQCfSchnfIQ4HhuZrOJAP7uX4mW4LJ5ISgsX8Qd/QEmu4x1miz4 JeKhAngSgBVk2tgS+/7tzv83w/BhsOsWh5i/Ijg6vSsM6ON3cfKmVn2797s9wd7ewyVv 7njQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=tqkcaX36QYOEALx41ugFpCOJXFRmtYPFxqx0EfjoXXE=; b=EcdGl3tTsgRqM0NwKmBNBejTpxnGv7Li/cZZlcfF2o4QWESJvvQjPbUa1DtfXV3pRN dQ/dMLzpF0Ncvl7LAVHJySPZr7QB2v8gOr9Hd8EQsN6EHfokgKVFOpu03K9EKevCH79S sZVydeGsclnfFBP0qX0KKG5SfB/BpvsB6/cim59G2JFsDCOmhUabeemw4lhDXR5ntE4B XjDEruJaymK36daUK0MpkuTq3liEMtrjBfdUK07t9Pn1U80bdLOgTElbe5DVAbROXxKD v0O8pJ+kZi5JkD7mHde3Jidd8Ix6qx1eSUgR2TErhr9PLsgXOTTzPUohwD1EmH/TgWb/ lXlg== X-Gm-Message-State: AEkoousVSPTgfeD4SuJyMM83qggYqf3xhR+SjrCc+aBGWB/kGXgM/sJ+Q/I5RioWLiQ8XqnS8Yuyz/nX9oD/sg== X-Received: by 10.37.57.85 with SMTP id g82mr23936800yba.163.1471359426210; Tue, 16 Aug 2016 07:57:06 -0700 (PDT) MIME-Version: 1.0 Received: by 10.13.201.71 with HTTP; Tue, 16 Aug 2016 07:57:05 -0700 (PDT) In-Reply-To: <201608161423.u7GENZJi021956@repo.freebsd.org> References: <201608161423.u7GENZJi021956@repo.freebsd.org> From: Ed Schouten Date: Tue, 16 Aug 2016 16:57:05 +0200 Message-ID: Subject: Re: svn commit: r304221 - head/sys/boot/efi/boot1 To: Emmanuel Vadot Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Aug 2016 14:57:07 -0000 Hi Emmanuel, 2016-08-16 16:23 GMT+02:00 Emmanuel Vadot : > Author: manu > Date: Tue Aug 16 14:23:35 2016 > New Revision: 304221 > URL: https://svnweb.freebsd.org/changeset/base/304221 > > Log: > Use %ju modifier for u_int64_t and %jd modifier for off_t. > off_t is long long on arm32 and long on amd64 I think both of these should be solved differently: - For uint64_t, you can use 's PRIu64 in the formatting string. In kernel space, I suspect you need to use something like . - For off_t, it's all right to print it with %jd, but then be sure to also add a cast to the argument itself. It may not necessarily be equal to an intmax_t. -- Ed Schouten Nuxi, 's-Hertogenbosch, the Netherlands KvK-nr.: 62051717