From owner-freebsd-hackers@FreeBSD.ORG Tue Nov 10 15:50:16 2009 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D6DB01065696; Tue, 10 Nov 2009 15:50:16 +0000 (UTC) (envelope-from a_best01@uni-muenster.de) Received: from zivm-exrelay1.uni-muenster.de (ZIVM-EXRELAY1.UNI-MUENSTER.DE [128.176.192.14]) by mx1.freebsd.org (Postfix) with ESMTP id 342348FC22; Tue, 10 Nov 2009 15:50:15 +0000 (UTC) X-IronPort-AV: E=Sophos;i="4.44,716,1249250400"; d="txt'?scan'208";a="287923233" Received: from zivmaildisp1.uni-muenster.de (HELO ZIVMAILUSER03.UNI-MUENSTER.DE) ([128.176.188.85]) by zivm-relay1.uni-muenster.de with ESMTP; 10 Nov 2009 16:50:14 +0100 Received: by ZIVMAILUSER03.UNI-MUENSTER.DE (Postfix, from userid 149459) id 70DF91B0751; Tue, 10 Nov 2009 16:50:14 +0100 (CET) Date: Tue, 10 Nov 2009 16:50:07 +0100 (CET) From: Alexander Best Sender: Organization: Westfaelische Wilhelms-Universitaet Muenster To: Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?= Message-ID: In-Reply-To: <863a4mg676.fsf@ds4.des.no> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary=+permail-200911101550071e86ffa800005ac8-a_best01+ Cc: freebsd-hackers@FreeBSD.org, Giorgos Keramidas Subject: Re: [patch] burncd: honour for envar SPEED X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Nov 2009 15:50:17 -0000 This is a MIME encoded multipart message. --+permail-200911101550071e86ffa800005ac8-a_best01+ Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Dag-Erling Sm=F8rgrav schrieb am 2009-11-10: > Alexander Best writes: > > good point. is this one better? > Yes (modulo indentation - run your code through tabify) > DES oops. found another problem. if BURNCD_SPEED and -s aren't defined strcasec= mp segfaults because env_speed is NULL. does this patch take care of the problem? alex ps: would be nice if strcasecmp could protect itself from segfault with one= or both of the args being NULL. --+permail-200911101550071e86ffa800005ac8-a_best01+ Content-Type: text/plain Content-Transfer-Encoding: Base64 Content-Disposition: attachment; filename="burncdspeedpatch.txt" SW5kZXg6IHVzci5zYmluL2J1cm5jZC9idXJuY2QuOAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSB1c3Iuc2Jpbi9i dXJuY2QvYnVybmNkLjgJKHJldmlzaW9uIDE5OTEyNSkKKysrIHVzci5zYmluL2J1cm5jZC9idXJu Y2QuOAkod29ya2luZyBjb3B5KQpAQCAtMjcsNyArMjcsNyBAQAogLlwiCiAuXCIgJEZyZWVCU0Qk CiAuXCIKLS5EZCBNYXkgMiwgMjAwNQorLkRkIE5vdiA5LCAyMDA5CiAuT3MKIC5EdCBCVVJOQ0Qg OAogLlNoIE5BTUUKQEAgLTE1OCw3ICsxNTgsMTEgQEAKIC5TaCBFTlZJUk9OTUVOVAogVGhlIGZv bGxvd2luZyBlbnZpcm9ubWVudCB2YXJpYWJsZXMgYWZmZWN0IHRoZSBleGVjdXRpb24gb2YKIC5O bSA6Ci0uQmwgLXRhZyAtd2lkdGggIi5FdiBDRFJPTSIKKy5CbCAtdGFnIC13aWR0aCAiLkV2IEJV Uk5DRF9TUEVFRCIKKy5JdCBFdiBCVVJOQ0RfU1BFRUQKK1RoZSB3cml0ZSBzcGVlZCB0byB1c2Ug aWYgb25lIGlzIG5vdCBzcGVjaWZpZWQgd2l0aCB0aGUKKy5GbCBzCitmbGFnLgogLkl0IEV2IENE Uk9NCiBUaGUgQ0QgZGV2aWNlIHRvIHVzZSBpZiBvbmUgaXMgbm90IHNwZWNpZmllZCB3aXRoIHRo ZQogLkZsIGYKSW5kZXg6IHVzci5zYmluL2J1cm5jZC9idXJuY2QuYwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSB1 c3Iuc2Jpbi9idXJuY2QvYnVybmNkLmMJKHJldmlzaW9uIDE5OTEyNSkKKysrIHVzci5zYmluL2J1 cm5jZC9idXJuY2QuYwkod29ya2luZyBjb3B5KQpAQCAtODAsMTEgKzgwLDEzIEBACiAJaW50IGRh byA9IDAsIGVqZWN0ID0gMCwgZml4YXRlID0gMCwgbGlzdCA9IDAsIG11bHRpID0gMCwgcHJlZW1w ID0gMDsKIAlpbnQgbm9nYXAgPSAwLCBzcGVlZCA9IDQgKiAxNzcsIHRlc3Rfd3JpdGUgPSAwLCBm b3JjZSA9IDA7CiAJaW50IGJsb2NrX3NpemUgPSAwLCBibG9ja190eXBlID0gMCwgY2RvcGVuID0g MCwgZHZkcncgPSAwOwotCWNvbnN0IGNoYXIgKmRldjsKKwljb25zdCBjaGFyICpkZXYsICplbnZf c3BlZWQ7CiAKIAlpZiAoKGRldiA9IGdldGVudigiQ0RST00iKSkgPT0gTlVMTCkKIAkJZGV2ID0g Ii9kZXYvYWNkMCI7CiAKKwllbnZfc3BlZWQgPSBnZXRlbnYoIkJVUk5DRF9TUEVFRCIpOworCiAJ d2hpbGUgKChjaCA9IGdldG9wdChhcmdjLCBhcmd2LCAiZGVmOkZsbW5wcXM6dHYiKSkgIT0gLTEp IHsKIAkJc3dpdGNoIChjaCkgewogCQljYXNlICdkJzoKQEAgLTEyNCwxMiArMTI2LDcgQEAKIAkJ CWJyZWFrOwogCiAJCWNhc2UgJ3MnOgotCQkJaWYgKHN0cmNhc2VjbXAoIm1heCIsIG9wdGFyZykg PT0gMCkKLQkJCQlzcGVlZCA9IENEUl9NQVhfU1BFRUQ7Ci0JCQllbHNlCi0JCQkJc3BlZWQgPSBh dG9pKG9wdGFyZykgKiAxNzc7Ci0JCQlpZiAoc3BlZWQgPD0gMCkKLQkJCQllcnJ4KEVYX1VTQUdF LCAiSW52YWxpZCBzcGVlZDogJXMiLCBvcHRhcmcpOworCQkJZW52X3NwZWVkID0gb3B0YXJnOwog CQkJYnJlYWs7CiAKIAkJY2FzZSAndCc6CkBAIC0xNDcsNiArMTQ0LDE1IEBACiAJYXJnYyAtPSBv cHRpbmQ7CiAJYXJndiArPSBvcHRpbmQ7CiAKKwlpZiAoZW52X3NwZWVkID09IE5VTEwpCisJCTsK KwllbHNlIGlmIChzdHJjYXNlY21wKCJtYXgiLCBlbnZfc3BlZWQpID09IDApCisJCXNwZWVkID0g Q0RSX01BWF9TUEVFRDsKKwllbHNlCisJCXNwZWVkID0gYXRvaShlbnZfc3BlZWQpICogMTc3Owor CWlmIChzcGVlZCA8PSAwKQorCQllcnJ4KEVYX1VTQUdFLCAiSW52YWxpZCBzcGVlZDogJXMiLCBv cHRhcmcpOworCiAJaWYgKGFyZ2MgPT0gMCkKIAkJdXNhZ2UoKTsKIAo= --+permail-200911101550071e86ffa800005ac8-a_best01+--