From owner-svn-src-stable-7@FreeBSD.ORG Wed Apr 8 17:46:49 2009 Return-Path: Delivered-To: svn-src-stable-7@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 24D381065689; Wed, 8 Apr 2009 17:46:49 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id ED3428FC1E; Wed, 8 Apr 2009 17:46:48 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [65.122.17.41]) by cyrus.watson.org (Postfix) with ESMTPS id A710146BA7; Wed, 8 Apr 2009 13:46:48 -0400 (EDT) Date: Wed, 8 Apr 2009 18:46:48 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Maxim Konovalov In-Reply-To: <20090408205159.X1212@mp2.macomnet.net> Message-ID: References: <200904080430.n384UGWw043589@svn.freebsd.org> <3bbf2fe10904080724i381c36fdpb1699def955fdb6d@mail.gmail.com> <20090408205159.X1212@mp2.macomnet.net> User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: src-committers@FreeBSD.ORG, svn-src-stable@FreeBSD.ORG, svn-src-all@FreeBSD.ORG, Stephen McKay , Attilio Rao , svn-src-stable-7@FreeBSD.ORG Subject: Re: svn commit: r190837 - in stable/7/sys: . contrib/pf dev/ath/ath_hal dev/cxgb kern X-BeenThere: svn-src-stable-7@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for only the 7-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Apr 2009 17:46:50 -0000 On Wed, 8 Apr 2009, Maxim Konovalov wrote: >>> While the probes I've added could be used to do this very easily, that's >>> not the thrust of the work I'm currently doing. A useful starting point >>> for someone interested in this problem would be a dtrace script like the >>> following: >>> >>> vfs:namecache:enter:done >> >> Also useful: the same script, but using "vfs:namecache:lookup:hit". >> > Perhaps we should start to put such scripts somewhere to src/tools. This sort of script isn't really worth putting in a library, as it's composed only of the most basic language constructs and a single probe. I'd rather reserve a tools tree for things that reflect a significant investment in time to write, rather than things that can be written in thirty seconds given a rudimentary knowledge of the D scripting language. Otherwise we'll be buried in scripts that have little utility and unable to find scripts that are useful. Something we do need to do is begin to formally document the sets of probes we're adding, because these sorts of trivial scripts become a lot more obvious it you know the probes exist and what they do :-). I'm not sure what the conventions for said man pages should be - perhaps vfs_probes(4) or vfs_dtrace(4) or the like, broken into a parts that include a summary of the goal of the provider, a list of the specific probes, etc? Robert N M Watson Computer Laboratory University of Cambridge