From owner-cvs-src@FreeBSD.ORG Sun Nov 6 23:55:56 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 07C2A16A41F; Sun, 6 Nov 2005 23:55:56 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222]) by mx1.FreeBSD.org (Postfix) with ESMTP id 995E643D46; Sun, 6 Nov 2005 23:55:55 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (unknown [192.168.48.2]) by phk.freebsd.dk (Postfix) with ESMTP id D66D2BC66; Sun, 6 Nov 2005 23:55:52 +0000 (UTC) To: Nate Lawson From: "Poul-Henning Kamp" In-Reply-To: Your message of "Sun, 06 Nov 2005 14:39:09 PST." <436E860D.6000201@root.org> Date: Mon, 07 Nov 2005 00:55:52 +0100 Message-ID: <8295.1131321352@critter.freebsd.dk> Sender: phk@critter.freebsd.dk Cc: =?ISO-8859-1?Q?Dag-Erling_Sm=F8rgrav?= , Mike Silbersack , src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sys/conf files src/sys/modules/acpi/acpi Makefile src/sys/dev/acpica acpi_battery.c acpi_smbat.c acpi_smbus.h acpiio.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Nov 2005 23:55:56 -0000 In message <436E860D.6000201@root.org>, Nate Lawson writes: >Poul-Henning Kamp wrote: >> In message <436E5797.7090605@root.org>, Nate Lawson writes: >>>I've said it many times: we need a real predictive algorithm. Taking a >>>single sample will always have hysteresis problems. >> >> >> I implemented my own algorithm and it works OK for me. Not perfect, >> but OK: >> http://phk.freebsd.dk/patch/powerd.patch > >I think that's what we have in -current, except we promote by 2 instead >of 3. That version was contributed by multiple people, including you >earlier. Is this version substantially different? Ahh ok, I wasn't aware that the stuff in the tree had been changed. I've found that a promotion by three steps felt better than just promoting by two steps, but this is a very subjective thing and it obviously depends on the size of the steps. A good strategy might be to let the decay remain at one, but make the promotion be controllable from the command line. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.