From owner-svn-ports-head@freebsd.org Wed Jun 22 06:27:59 2016 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B800CAC5CC8; Wed, 22 Jun 2016 06:27:59 +0000 (UTC) (envelope-from matthew@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 73E2E16AB; Wed, 22 Jun 2016 06:27:59 +0000 (UTC) (envelope-from matthew@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id u5M6Rwut059923; Wed, 22 Jun 2016 06:27:58 GMT (envelope-from matthew@FreeBSD.org) Received: (from matthew@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id u5M6RwkW059922; Wed, 22 Jun 2016 06:27:58 GMT (envelope-from matthew@FreeBSD.org) Message-Id: <201606220627.u5M6RwkW059922@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: matthew set sender to matthew@FreeBSD.org using -f From: Matthew Seaman Date: Wed, 22 Jun 2016 06:27:58 +0000 (UTC) To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: svn commit: r417292 - head/Mk/Uses X-SVN-Group: ports-head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Jun 2016 06:27:59 -0000 Author: matthew Date: Wed Jun 22 06:27:58 2016 New Revision: 417292 URL: https://svnweb.freebsd.org/changeset/ports/417292 Log: WANT_PGSQL=lib adds a LIB_DEPENDS on postgresglXY-client (this is also the default when WANT_PGSQL is not defined). Compare to WANT_PGSQL=client which only adds a RUN_DEPENDS on postgresqlXY-client. 'client' can be part of a list of different components, but 'lib' is ignored if any other terms are specified, which seems an arbitrary and incorrect restriction. WANT_PGSQL=lib allows expressing that the port links against libpq.so.X rather than just needing one of the client programs like psql(1) at runtime. However, other than that there is little practical difference between 'lib' and 'client' on the resulting pkg. Approved by: crees (pgsql@) Sponsored by: https://reviews.freebsd.org/D6893 Modified: head/Mk/Uses/pgsql.mk Modified: head/Mk/Uses/pgsql.mk ============================================================================== --- head/Mk/Uses/pgsql.mk Wed Jun 22 06:19:53 2016 (r417291) +++ head/Mk/Uses/pgsql.mk Wed Jun 22 06:27:58 2016 (r417292) @@ -130,7 +130,7 @@ IGNORE?= cannot install: does not work . endfor . endif # IGNORE_WITH_PGSQL -.if !defined(WANT_PGSQL) || ${WANT_PGSQL} == lib +.if !defined(WANT_PGSQL) || ${WANT_PGSQL:Mlib} LIB_DEPENDS+= libpq.so.${PGSQL${PGSQL_VER_NODOT}_LIBVER}:databases/postgresql${PGSQL_VER_NODOT}-client .endif