From owner-cvs-all Sun Mar 11 10: 8:51 2001 Delivered-To: cvs-all@freebsd.org Received: from flood.ping.uio.no (flood.ping.uio.no [129.240.78.31]) by hub.freebsd.org (Postfix) with ESMTP id 906CB37B718; Sun, 11 Mar 2001 10:08:45 -0800 (PST) (envelope-from des@ofug.org) Received: (from des@localhost) by flood.ping.uio.no (8.9.3/8.9.3) id TAA36379; Sun, 11 Mar 2001 19:08:44 +0100 (CET) (envelope-from des@ofug.org) X-URL: http://www.ofug.org/~des/ X-Disclaimer: The views expressed in this message do not necessarily coincide with those of any organisation or company with which I am or have been affiliated. To: John Baldwin Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/alpha/linux linux_machdep.c References: <200103060255.f262tO937760@freefall.freebsd.org> From: Dag-Erling Smorgrav Date: 11 Mar 2001 19:08:43 +0100 In-Reply-To: John Baldwin's message of "Mon, 5 Mar 2001 18:55:23 -0800 (PST)" Message-ID: Lines: 17 User-Agent: Gnus/5.0802 (Gnus v5.8.2) Emacs/20.4 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG John Baldwin writes: > Log: > Create clone'd linux processes as stopped processes at first and don't > actually make them runnable until after the emulator layer has had a chance > to perform fixups. This commit is wrong: rfork() masks away RFSTOPPED, so fork1() queues the process, then linux_clone() queues it once again. This would have gotten caught if runq_add() asserted that it didn't get passed an already-queued process. The corresponding commit to src/sys/alpha/linux/linux_machdep.c is of course also incorrect. DES -- Dag-Erling Smorgrav - des@ofug.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message