From owner-svn-src-user@FreeBSD.ORG Sun Nov 9 00:49:36 2008 Return-Path: Delivered-To: svn-src-user@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C5E491065676; Sun, 9 Nov 2008 00:49:36 +0000 (UTC) (envelope-from kmacy@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id B62458FC1F; Sun, 9 Nov 2008 00:49:36 +0000 (UTC) (envelope-from kmacy@FreeBSD.org) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id mA90nafn026213; Sun, 9 Nov 2008 00:49:36 GMT (envelope-from kmacy@svn.freebsd.org) Received: (from kmacy@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id mA90naJr026212; Sun, 9 Nov 2008 00:49:36 GMT (envelope-from kmacy@svn.freebsd.org) Message-Id: <200811090049.mA90naJr026212@svn.freebsd.org> From: Kip Macy Date: Sun, 9 Nov 2008 00:49:36 +0000 (UTC) To: src-committers@freebsd.org, svn-src-user@freebsd.org X-SVN-Group: user MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r184776 - user/kmacy/HEAD_fast_multi_xmit/sys/net X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 09 Nov 2008 00:49:36 -0000 Author: kmacy Date: Sun Nov 9 00:49:36 2008 New Revision: 184776 URL: http://svn.freebsd.org/changeset/base/184776 Log: validate rtentry before doing any other checks Modified: user/kmacy/HEAD_fast_multi_xmit/sys/net/flowtable.c Modified: user/kmacy/HEAD_fast_multi_xmit/sys/net/flowtable.c ============================================================================== --- user/kmacy/HEAD_fast_multi_xmit/sys/net/flowtable.c Sun Nov 9 00:38:11 2008 (r184775) +++ user/kmacy/HEAD_fast_multi_xmit/sys/net/flowtable.c Sun Nov 9 00:49:36 2008 (r184776) @@ -599,8 +599,9 @@ static __inline int gw_valid(struct rtentry *rt) { return ((rt->rt_flags & RTF_GATEWAY) == 0 || - ((rt->rt_flags & RTF_GATEWAY) && - (rt->rt_gwroute->rt_flags & RTF_UP))); + ((rt->rt_flags & RTF_GATEWAY) + && (rt->rt_gwroute != NULL) + && (rt->rt_gwroute->rt_flags & RTF_UP))); } @@ -642,7 +643,8 @@ flowtable_lookup(struct flowtable *ft, s FL_ENTRY_LOCK(ft, hash); fle = FL_ENTRY(ft, hash); rt = __DEVOLATILE(struct rtentry *, fle->f_rt); - if (fle->f_fhash == hash + if ((rt != NULL) + && fle->f_fhash == hash && flowtable_key_equal(fle, key, flags) && (proto == fle->f_proto) && (rt->rt_flags & RTF_UP)