From owner-cvs-src@FreeBSD.ORG Sun Apr 6 05:36:57 2008 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B958A106566B; Sun, 6 Apr 2008 05:36:57 +0000 (UTC) (envelope-from grog@lemis.com) Received: from ozlabs.org (ozlabs.org [203.10.76.45]) by mx1.freebsd.org (Postfix) with ESMTP id 3E9C58FC19; Sun, 6 Apr 2008 05:36:57 +0000 (UTC) (envelope-from grog@lemis.com) Received: from dereel.lemis.com (ozlabs.org [203.10.76.45]) by ozlabs.org (Postfix) with ESMTP id 6DAA2DDDE9; Sun, 6 Apr 2008 15:36:54 +1000 (EST) Received: by dereel.lemis.com (Postfix, from userid 1004) id 7BD54229AA; Sun, 6 Apr 2008 15:36:48 +1000 (EST) Date: Sun, 6 Apr 2008 15:36:48 +1000 From: Greg 'groggy' Lehey To: Coleman Kane Message-ID: <20080406053648.GC27705@dereel.lemis.com> References: <200804040357.m343vlQ8083007@repoman.freebsd.org> <20080405193851.J66744@maildrop.int.zabbadoz.net> <20080405234758.GB27705@dereel.lemis.com> <47F81C48.1040103@FreeBSD.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="S1BNGpv0yoYahz37" Content-Disposition: inline In-Reply-To: <47F81C48.1040103@FreeBSD.org> User-Agent: Mutt/1.4.2.3i Organization: The FreeBSD Project Phone: +61-3-5346-1370 Mobile: +61-418-838-708 WWW-Home-Page: http://www.FreeBSD.org/ X-PGP-Fingerprint: 9A1B 8202 BCCE B846 F92F 09AC 22E6 F290 507A 4223 Cc: cvs-src@FreeBSD.org, "Bjoern A. Zeeb" , cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/bin/ls ls.1 ls.c ls.h print.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Apr 2008 05:36:57 -0000 --S1BNGpv0yoYahz37 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Saturday, 5 April 2008 at 20:41:44 -0400, Coleman Kane wrote: > Greg 'groggy' Lehey wrote: >> On Saturday, 5 April 2008 at 19:40:02 +0000, Bjoern A. Zeeb wrote: >> >>> On Fri, 4 Apr 2008, Greg Lehey wrote: >>> >>> >>>> grog 2008-04-04 03:57:47 UTC >>>> >>>> FreeBSD src repository >>>> >>>> Modified files: >>>> bin/ls ls.1 ls.c ls.h print.c >>>> Log: >>>> Add -D option to specify exact format of date and time output with ls -l. >>>> >>> I think something went wrong here. Could you please fix this. Thanks. >>> >>> bz@dopt:/local/building/freebsd/HEAD/bin/ls> ll >>> total 80 >>> drwxr-xr-x 2 bz wheel 512 Apr 5 15:18 CVS/ >>> -rw-r--r-- 1 bz wheel 300 May 25 2004 Makefile >>> -rw-r--r-- 1 bz wheel 4803 Mar 24 2006 cmp.c >>> -rw-r--r-- 1 bz wheel 2852 Mar 24 2006 extern.h >>> >> >> Ugh. My editor was a little too zealous in replacing spaces with tabs :-( > > Uhm.... shouldn't this be "\t" instead of the actualy tab character > (0x08)? No. It should be two spaces. Here's the diff :-) --- print.c 4 Apr 2008 03:57:46 -0000 1.77 +++ print.c 5 Apr 2008 23:44:24 -0000 @@ -388,7 +388,7 @@ format = d_first ? "%e %b %R" : "%b %e %R"; else /* mmm dd yyyy || dd mmm yyyy */ - format = d_first ? "%e %b %Y" : "%b %e %Y"; + format = d_first ? "%e %b %Y" : "%b %e %Y"; strftime(longstring, sizeof(longstring), format, localtime(&ftime)); For reasons lost in the mists of time, there are two spaces before the %Y in this format, but my editor accidentally replaced them with a tab character. As you can see, that's not immediately obvious. Greg -- See complete headers for address and phone numbers. --S1BNGpv0yoYahz37 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFH+GFvIubykFB6QiMRAsOnAJ9B+QF3HoopXn8FhA8FE5VvLHMx1wCfV3Ki jIurFfP8NqUrd92O6aXOKNs= =MF8f -----END PGP SIGNATURE----- --S1BNGpv0yoYahz37--