From owner-cvs-all@FreeBSD.ORG Thu Apr 24 00:40:30 2008 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2364C106567D for ; Thu, 24 Apr 2008 00:40:30 +0000 (UTC) (envelope-from peter@wemm.org) Received: from an-out-0708.google.com (an-out-0708.google.com [209.85.132.246]) by mx1.freebsd.org (Postfix) with ESMTP id DFE8C8FC24 for ; Thu, 24 Apr 2008 00:40:29 +0000 (UTC) (envelope-from peter@wemm.org) Received: by an-out-0708.google.com with SMTP id c14so822073anc.13 for ; Wed, 23 Apr 2008 17:40:29 -0700 (PDT) Received: by 10.100.205.9 with SMTP id c9mr4100963ang.51.1208997628919; Wed, 23 Apr 2008 17:40:28 -0700 (PDT) Received: by 10.100.8.6 with HTTP; Wed, 23 Apr 2008 17:40:28 -0700 (PDT) Message-ID: Date: Wed, 23 Apr 2008 17:40:28 -0700 From: "Peter Wemm" To: "John Baldwin" In-Reply-To: <200804230858.31200.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200804190725.m3J7Pvie056329@repoman.freebsd.org> <200804230858.31200.jhb@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/amd64/amd64 machdep.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Apr 2008 00:40:30 -0000 On Wed, Apr 23, 2008 at 5:58 AM, John Baldwin wrote: > On Saturday 19 April 2008 03:25:57 am Peter Wemm wrote: > > peter 2008-04-19 07:25:57 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/amd64/amd64 machdep.c > > Log: > > Put in a real isa_irq_pending() stub in order to remove two lines of > > dmesg noise from sio per unit. sio likes to probe if interrupts are > > configured correctly by looking at the pending bits of the atpic in order > > to put a non-fatal warning on the console. I think I'd rather read the > > pending bits from the apics, but I'm not sure its worth the hassle. > > Actually, the x86 interrupt sources have a pending method so this can be > replaced. Could probably easily write something like this: > > int > intr_pending(u_int irq) > { > struct intsrc *isrc; > > isc = intr_lookup_source(irq); > if (isrc == NULL) > panic("bizarre"); > return (isrc->is_pic->pic_pending(isrc)); > } > > For intr_machdep.c and use this in sio: > > #if defined(__i386__) || defined(__amd64__) > foo = intr_pending(rman_get_start(irq_resource)); > #else > foo = isa_irq_pending() & (1 << rman_get_start(irq_resource)); > #endif > > or some such. I'd really prefer to kill isa_irq_pending(). Let's just add intr_pending() to all MD backends that currently provide isa_irq_pending() for sio's benenfit. Either as a simple wrapper around the now-static local isa_irq_pending() (ia64), or by simplifying and converting isa_irq_pending() into intr_pending() (sparc64). -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com "All of this is for nothing if we don't go to the stars" - JMS/B5 "If Java had true garbage collection, most programs would delete themselves upon execution." -- Robert Sewell