From owner-cvs-all@FreeBSD.ORG Wed May 28 14:32:47 2008 Return-Path: Delivered-To: cvs-all@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D541A1065671; Wed, 28 May 2008 14:32:47 +0000 (UTC) (envelope-from kensmith@cse.Buffalo.EDU) Received: from phoebe.cse.buffalo.edu (phoebe.cse.buffalo.edu [128.205.32.89]) by mx1.freebsd.org (Postfix) with ESMTP id 93D818FC12; Wed, 28 May 2008 14:32:47 +0000 (UTC) (envelope-from kensmith@cse.Buffalo.EDU) Received: from [128.205.32.76] (bauer.cse.buffalo.edu [128.205.32.76]) (authenticated bits=0) by phoebe.cse.buffalo.edu (8.14.1/8.13.7) with ESMTP id m4SDtf59006500 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 28 May 2008 09:55:42 -0400 (EDT) (envelope-from kensmith@cse.buffalo.edu) From: Ken Smith To: d@delphij.net In-Reply-To: <483C977F.20105@delphij.net> References: <200805272004.m4RK4SZt029194@repoman.freebsd.org> <483C7FF2.6000607@FreeBSD.org> <483C977F.20105@delphij.net> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-4tXbilFueFXGh9jP5CRL" Organization: U. Buffalo CSE Department Date: Wed, 28 May 2008 09:55:41 -0400 Message-Id: <1211982941.57965.8.camel@bauer.cse.buffalo.edu> Mime-Version: 1.0 X-Mailer: Evolution 2.12.1 FreeBSD GNOME Team Port X-DCC-Buffalo.EDU-Metrics: phoebe.cse.buffalo.edu 1029; Body=0 Fuz1=0 Fuz2=0 Cc: Maxim Sobolev , src-committers@FreeBSD.ORG, re@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG, Xin LI Subject: Re: cvs commit: src/include string.h src/lib/libc/string Makefile.inc memchr.3 memrchr.c src/sys/sys param.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 May 2008 14:32:48 -0000 --=-4tXbilFueFXGh9jP5CRL Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Tue, 2008-05-27 at 16:21 -0700, Xin LI wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 >=20 > Maxim Sobolev wrote: > | Xin LI wrote: > |> delphij 2008-05-27 20:04:27 UTC > |> > |> FreeBSD src repository > |> > |> Modified files: (Branch: RELENG_6) > |> include string.h lib/libc/string > |> Makefile.inc memchr.3 sys/sys param.h Added > |> files: (Branch: RELENG_6) > |> lib/libc/string memrchr.c Log: > |> MFC: Add memrchr(3). > | > | I think this is not very good idea to MFC that into stable releases 6.x > | and 7.x. The reason is that configure scripts for some packages might > | detect up this API and enable it. Which means that some binary-only > | packages build for say 6.4 won't work on 6.3 and down. AFAIK, both > | forward and backward compatibility is required (or at least desired?) > | for stable branches. > | > | While it's "nice-to-have" feature, I see no pressing need to MFC this > | interface. >=20 > I don't think so, perhaps I am wrong, but do we really want absolutely > no *new* features on -STABLE branches? I think this case is different > from ctype(3) fix which is widely used API and a change of existing > interface by adding new dependency to a symbol that is not exist in the > older FreeBSD releases. It will really scare me away from any new > features if we can not add an new interface in RELENG_* trees even if > they have no outside dependencies, if that's the policy of ABI > compatibility guidelines then I'd be happy to revert these MFC's, but > having something can only run on -CURRENT does not sound like a good > idea, and maintaining in-tree alternative patches for different branches > for such things is really painful and will likely reduce the lifespan of > given -STABLE branches, is these our goal and should be kept in mind > when maintaining code in RELENG_* branches? I'm inclined towards letting this stay in. The ctype(3) fix altered an existing interface in a way that made it incompatible with older stuff. This is adding new stuff. The "forwards compatibility" is a good thing for people trying to use pre-built packages on older systems but this one is a case of us trying to avoid breakage that, if it were to occur, would be at the whims of the configure script for the packages. I think that's pushing the notion of forwards compatibility a tiny bit too far. --=20 Ken Smith - From there to here, from here to | kensmith@cse.buffalo.edu there, funny things are everywhere. | - Theodore Geisel | --=-4tXbilFueFXGh9jP5CRL Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (FreeBSD) iD8DBQBIPWRV/G14VSmup/YRAnt6AKCDcCl8KrjnwnQi5+RasJk7Sn9NnQCfUwpG QVUybAgcoDGxBCGLnjp9VZA= =lIl7 -----END PGP SIGNATURE----- --=-4tXbilFueFXGh9jP5CRL--