From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Jun 5 18:20:06 2011 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0B5E4106564A for ; Sun, 5 Jun 2011 18:20:05 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id C93298FC15 for ; Sun, 5 Jun 2011 18:20:05 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p55IK5BE074727 for ; Sun, 5 Jun 2011 18:20:05 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p55IK5Pw074726; Sun, 5 Jun 2011 18:20:05 GMT (envelope-from gnats) Resent-Date: Sun, 5 Jun 2011 18:20:05 GMT Resent-Message-Id: <201106051820.p55IK5Pw074726@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Chris Rees Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9C298106566C for ; Sun, 5 Jun 2011 18:18:40 +0000 (UTC) (envelope-from utisoft@hotmail.com) Received: from blu0-omc1-s29.blu0.hotmail.com (blu0-omc1-s29.blu0.hotmail.com [65.55.116.40]) by mx1.freebsd.org (Postfix) with ESMTP id 538CA8FC13 for ; Sun, 5 Jun 2011 18:18:39 +0000 (UTC) Received: from BLU0-SMTP152 ([65.55.116.9]) by blu0-omc1-s29.blu0.hotmail.com with Microsoft SMTPSVC(6.0.3790.4675); Sun, 5 Jun 2011 11:18:39 -0700 Received: from zeus.bayofrum.net ([90.221.7.100]) by BLU0-SMTP152.phx.gbl over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Sun, 5 Jun 2011 11:18:34 -0700 Received: from zeus.bayofrum.net (crees@localhost [127.0.0.1]) by zeus.bayofrum.net (8.14.4/8.14.4) with ESMTP id p55IHsIj097623 (version=TLSv1/SSLv3 cipher=DHE-DSS-AES256-SHA bits=256 verify=NO) for ; Sun, 5 Jun 2011 19:17:54 +0100 (BST) (envelope-from chris@zeus.bayofrum.net) Received: (from crees@localhost) by zeus.bayofrum.net (8.14.4/8.14.4/Submit) id p55IHrWN097609; Sun, 5 Jun 2011 19:17:53 +0100 (BST) (envelope-from chris) Message-Id: Date: Sun, 5 Jun 2011 19:17:53 +0100 From: Chris Rees Sender: To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/157630: [PATCH] Fix port: net/yate-devel should use USERS X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Chris Rees List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Jun 2011 18:20:06 -0000 >Number: 157630 >Category: ports >Synopsis: [PATCH] Fix port: net/yate-devel should use USERS >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Sun Jun 05 18:20:05 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Chris Rees >Release: FreeBSD 8.2-RELEASE-p1 i386 >Organization: bayofrum >Environment: System: FreeBSD zeus.bayofrum.net 8.2-RELEASE-p1 FreeBSD 8.2-RELEASE-p1 #0: Sat Apr 30 15:09:06 BST 2011 root@zeus.bayofrum.net:/usr/obj/usr/src/sys/ZEUS i386 >Description: This port uses pkg-install to create new users instead of using USERS= and GROUPS= XXXXXXXXXX Because it's marked BROKEN, I haven't Tinderbox checked it. Balwinder, please would you incorporate this patch into your fix? XXXXXXXXXX >How-To-Repeat: >Fix: - Use USERS and GROUPS Submitted by: Chris Rees (utisoft@gmail.com) --- yate-devel.patch begins here --- Index: Makefile =================================================================== RCS file: /exports/cvsroot-freebsd/ports/net/yate-devel/Makefile,v retrieving revision 1.16 diff -u -r1.16 Makefile --- Makefile 20 Jan 2011 17:38:16 -0000 1.16 +++ Makefile 31 May 2011 19:37:36 -0000 @@ -47,6 +47,8 @@ H323 "H323 software channel/protocol support" on \ FAX "Fax software channel/driver support" off +USERS= ${PORTNAME} +GROUPS= ${USERS} DOCSDIR= ${LOCALBASE}/share/doc/yate PLIST_SUB= BRISTUFF="@comment " PLIST_SUB+= VERSION=${PORTVERSION:S/.p2//} Index: pkg-install =================================================================== RCS file: pkg-install diff -N pkg-install --- pkg-install 23 Sep 2007 12:34:40 -0000 1.1 +++ /dev/null 1 Jan 1970 00:00:00 -0000 @@ -1,35 +0,0 @@ -#!/bin/sh -# $FreeBSD: ports/net/yate-devel/pkg-install,v 1.1 2007/09/23 12:34:40 edwin Exp $ -# - -if [ "$2" != "PRE-INSTALL" ]; then - exit 0 -fi - -YATE_USER=yate -YATE_GROUP=${YATE_USER} -YATE_UID=204 -YATE_GID=${YATE_UID} - -if ! pw groupshow "${YATE_GROUP}" 2>/dev/null 1>&2; then - if pw groupadd ${YATE_GROUP} -g ${YATE_GID}; then - echo "Added group \"${YATE_GROUP}\"." - else - echo "Adding group \"${YATE_GROUP}\" failed..." - exit 1 - fi -fi - -if ! pw usershow "${YATE_USER}" 2>/dev/null 1>&2; then - if pw useradd ${YATE_USER} -u ${YATE_UID} -g ${YATE_GROUP} -h - \ - -s "/sbin/nologin" -d "/nonexistent" \ - -c "Yate Telephoney Server"; \ - then - echo "Added user \"${YATE_USER}\"." - else - echo "Adding user \"${YATE_USER}\" failed..." - exit 1 - fi -fi - -exit 0 --- yate-devel.patch ends here --- -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean. >Release-Note: >Audit-Trail: >Unformatted: