From owner-freebsd-bugs@FreeBSD.ORG Thu Sep 20 16:00:23 2012 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B89BF1065670 for ; Thu, 20 Sep 2012 16:00:23 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 633588FC0C for ; Thu, 20 Sep 2012 16:00:23 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q8KG0Ns0037082 for ; Thu, 20 Sep 2012 16:00:23 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q8KG0NQM037081; Thu, 20 Sep 2012 16:00:23 GMT (envelope-from gnats) Resent-Date: Thu, 20 Sep 2012 16:00:23 GMT Resent-Message-Id: <201209201600.q8KG0NQM037081@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Ben Wilber Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 85B4E106566B for ; Thu, 20 Sep 2012 15:56:15 +0000 (UTC) (envelope-from bw@exile.desync.com) Received: from exile.desync.com (exile.desync.com [IPv6:2607:f178::167]) by mx1.freebsd.org (Postfix) with ESMTP id 0F2378FC0A for ; Thu, 20 Sep 2012 15:56:14 +0000 (UTC) Received: by exile.desync.com (Postfix, from userid 666) id 0B46B2D92; Thu, 20 Sep 2012 11:56:15 -0400 (EDT) Message-Id: <20120920155615.0B46B2D92@exile.desync.com> Date: Thu, 20 Sep 2012 11:56:15 -0400 (EDT) From: Ben Wilber To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: kern/171811: [patch] rctl(8) cputime is too high X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Ben Wilber List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Sep 2012 16:00:23 -0000 >Number: 171811 >Category: kern >Synopsis: [patch] rctl(8) cputime is too high >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Sep 20 16:00:22 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Ben Wilber >Release: FreeBSD 10.0-CURRENT amd64 >Organization: >Environment: System: FreeBSD exile 10.0-CURRENT FreeBSD 10.0-CURRENT #1 r240178M: Thu Sep 6 19:25:33 EDT 2012 bw@exodus:/usr/obj/usr/src/sys/COMRADE amd64 >Description: rctl's idea of cputime is unreasonably high with lots of process turnover. >How-To-Repeat: # jail -c command=sh jail# while true; do id > /dev/null; done meanwhile: # dtrace -n 'rusage:add-cred/args[0]->cr_prison->pr_id != 0 && args[1] == 0/{printf("%d: jail %d cputime %d", pid, args[0]->cr_prison->pr_id, args[2])}' 5 57139 rusage:add-cred 37375: jail 5 cputime 124211 5 57139 rusage:add-cred 37375: jail 5 cputime 6330 5 57139 rusage:add-cred 37375: jail 5 cputime 51237828 5 57139 rusage:add-cred 37375: jail 5 cputime 173602 5 57139 rusage:add-cred 37375: jail 5 cputime 6834680 (...) >Fix: Attached patch seems to help. --- kern_racct.diff begins here --- Index: kern_racct.c =================================================================== diff --git a/head/sys/kern/kern_racct.c b/head/sys/kern/kern_racct.c --- a/head/sys/kern/kern_racct.c (revision 240705) +++ b/head/sys/kern/kern_racct.c (working copy) @@ -607,7 +607,9 @@ /* * We don't need to calculate rux, proc_reap() has already done this. */ + PROC_SLOCK(p); runtime = cputick2usec(p->p_rux.rux_runtime); + PROC_SUNLOCK(p); #ifdef notyet KASSERT(runtime >= p->p_prev_runtime, ("runtime < p_prev_runtime")); #else --- kern_racct.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted: