From owner-svn-ports-head@FreeBSD.ORG  Tue May 21 02:34:48 2013
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id ACE182D1; Tue, 21 May 2013 02:34:48 +0000 (UTC)
Date: Tue, 21 May 2013 02:34:48 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Boris Samorodov <bsam@FreeBSD.org>
Subject: Re: svn commit: r318592 - head/benchmarks/mdtest
Message-ID: <20130521023448.GA3541@FreeBSD.org>
References: <201305201043.r4KAhCKv031239@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201305201043.r4KAhCKv031239@svn.freebsd.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 21 May 2013 02:34:48 -0000

On Mon, May 20, 2013 at 10:43:12AM +0000, Boris Samorodov wrote:
> New Revision: 318592
> URL: http://svnweb.freebsd.org/changeset/ports/318592
> 
>  do-install:
> -	${INSTALL_PROGRAM} ${WRKSRC}/${PORTNAME} ${PREFIX}/bin
> -	${INSTALL_MAN} ${WRKSRC}/${PORTNAME}.1 ${MANPREFIX}/man/man1
> +	(cd ${WRKSRC} && ${INSTALL_PROGRAM} ${PORTNAME} ${PREFIX}/bin)
> +	(cd ${WRKSRC} && ${INSTALL_MAN} ${PORTNAME}.1 ${MANPREFIX}/man/man1)
>  .if ${PORT_OPTIONS:MEXAMPLES}
>  	@${MKDIR} ${EXAMPLESDIR}
> -	@(cd ${WRKSRC}/scripts && ${COPYTREE_SHARE} \* ${EXAMPLESDIR})
> +	(cd ${WRKSRC}/scripts && ${INSTALL_DATA} * ${EXAMPLESDIR})

These changes are gratuitous (at least), plus I've already raised my
concerns about Kato's desire to make every INSTALL_* command needlessly
depended on current directory.  Not just it makes command line longer,
it looks worse it logs and requires reader to parse two command instead
of one.  I am also not convinced that using subshell is required.

Asterisk should have been replaced with dot as a safer alternative that
is not special shell symbol and thus does not require escaping (or worry
about it).

Given that changes are probably technically correct (Kato is usually good
on that side), I would like to reinterate that their (or whomever else)
submissions should not be committed blindly as they are.

./danfe