From owner-freebsd-current@FreeBSD.ORG  Fri Aug  8 03:01:24 2003
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 9B96C37B401
	for <current@freebsd.org>; Fri,  8 Aug 2003 03:01:24 -0700 (PDT)
Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua
	[212.110.138.65])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 6753643FB1
	for <current@freebsd.org>; Fri,  8 Aug 2003 03:01:18 -0700 (PDT)
	(envelope-from ru@sunbay.com)
Received: from whale.sunbay.crimea.ua (ru@localhost [127.0.0.1])
	h78A18fr041292
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Fri, 8 Aug 2003 13:01:10 +0300 (EEST)	(envelope-from ru@sunbay.com)
Received: (from ru@localhost)
	by whale.sunbay.crimea.ua (8.12.9/8.12.8/Submit) id h78A155U041278;
	Fri, 8 Aug 2003 13:01:05 +0300 (EEST)
	(envelope-from ru)
Date: Fri, 8 Aug 2003 13:01:05 +0300
From: Ruslan Ermilov <ru@freebsd.org>
To: Andrew Turner <zombie@i4free.co.nz>
Message-ID: <20030808100105.GB40307@sunbay.com>
References: <20030807074557.S75796@root.org> <3F32DFFD.4060402@i4free.co.nz>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="jho1yZJdad60DJr+"
Content-Disposition: inline
In-Reply-To: <3F32DFFD.4060402@i4free.co.nz>
User-Agent: Mutt/1.5.4i
cc: current@freebsd.org
cc: Nate Lawson <nate@root.org>
Subject: Re: Warning with loader Makefile?
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 08 Aug 2003 10:01:24 -0000


--jho1yZJdad60DJr+
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Aug 08, 2003 at 11:25:49AM +1200, Andrew Turner wrote:
[...]
> I found this patch worked by removing the secound ${PROG} target if=20
> there was already one there.
>=20
> --- /usr/src/share/mk/bsd.prog.mk	Mon Jun 30 06:16:26 2003
> +++ /usr/share/mk/bsd.prog.mk	Mon Aug  4 17:54:22 2003
> @@ -31,11 +31,13 @@
> =20
>  OBJS+=3D  ${SRCS:N*.h:R:S/$/.o/g}
> =20
> +.if !target(${PROG})
>  ${PROG}: ${OBJS}
>  .if defined(PROG_CXX)
>  	${CXX} ${CXXFLAGS} ${LDFLAGS} -o ${.TARGET} ${OBJS} ${LDADD}
>  .else
>  	${CC} ${CFLAGS} ${LDFLAGS} -o ${.TARGET} ${OBJS} ${LDADD}
> +.endif
>  .endif
> =20
>  .else !defined(SRCS)

No, thanks.  If a makefile has a

${PROG}: foo

line, just to add an additional dependency, this patch will break
building the ${PROG}.


Cheers,
--=20
Ruslan Ermilov		Sysadmin and DBA,
ru@sunbay.com		Sunbay Software Ltd,
ru@FreeBSD.org		FreeBSD committer

--jho1yZJdad60DJr+
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (FreeBSD)

iD8DBQE/M3TgUkv4P6juNwoRAlLTAJ9Qj9B+tpX76DLGhUlrzVfRUHud2ACfdDoT
yZFH4CZ6HxPEVRu82l8eOw0=
=3oev
-----END PGP SIGNATURE-----

--jho1yZJdad60DJr+--