From owner-freebsd-current@FreeBSD.ORG Wed Jun 23 02:20:20 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B48F716A4CF for ; Wed, 23 Jun 2004 02:20:20 +0000 (GMT) Received: from harmony.village.org (rover.village.org [168.103.84.182]) by mx1.FreeBSD.org (Postfix) with ESMTP id 50CE043D54 for ; Wed, 23 Jun 2004 02:20:20 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.12.11/8.12.11) with ESMTP id i5N2GWQQ041829; Tue, 22 Jun 2004 20:16:32 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Tue, 22 Jun 2004 20:16:41 -0600 (MDT) Message-Id: <20040622.201641.91309536.imp@bsdimp.com> To: bms@spc.org From: "M. Warner Losh" In-Reply-To: <20040622230406.GJ762@empiric.dek.spc.org> References: <20040622230406.GJ762@empiric.dek.spc.org> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: freebsd-current@freebsd.org cc: naddy@mips.inka.de Subject: Re: Optimized ether_crc32_be() X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jun 2004 02:20:20 -0000 In message: <20040622230406.GJ762@empiric.dek.spc.org> Bruce M Simpson writes: : On Fri, Jun 18, 2004 at 11:37:40PM +0000, Christian Weisgerber wrote: : > Taken from kern/49957, here's a table-driven implementation of : > ether_crc32_be() to complement the little-endian one. For 6-byte : > MAC addresses it's about five times faster than the double loop. : > : > Comments? : : This sounds like a good idea. I'd be happy to see this committed : (providing, as phk@ suggested, that it is subject to proper regression : testing) as it may help to address the GPL contamination thread discussed : in May's Core Monthly Report (specifically in sk(4)). That issue is already resolved. ether_crc32_be can help in the future keeping such code from being committed, but the GPL'd code has already been eliminated from the driver. Warner