From owner-freebsd-bugs@FreeBSD.ORG Fri Nov 23 09:40:01 2012 Return-Path: Delivered-To: freebsd-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 1A4B960D for ; Fri, 23 Nov 2012 09:40:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id E14808FC13 for ; Fri, 23 Nov 2012 09:40:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id qAN9e0RT056095 for ; Fri, 23 Nov 2012 09:40:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id qAN9e099056090; Fri, 23 Nov 2012 09:40:00 GMT (envelope-from gnats) Resent-Date: Fri, 23 Nov 2012 09:40:00 GMT Resent-Message-Id: <201211230940.qAN9e099056090@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Matt Smith Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 79DE61F4 for ; Fri, 23 Nov 2012 09:31:19 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id 629FD8FC08 for ; Fri, 23 Nov 2012 09:31:19 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.5/8.14.5) with ESMTP id qAN9VILS007685 for ; Fri, 23 Nov 2012 09:31:18 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.5/8.14.5/Submit) id qAN9VI67007677; Fri, 23 Nov 2012 09:31:18 GMT (envelope-from nobody) Message-Id: <201211230931.qAN9VI67007677@red.freebsd.org> Date: Fri, 23 Nov 2012 09:31:18 GMT From: Matt Smith To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: conf/173857: Mistake in newsyslog.conf X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Nov 2012 09:40:01 -0000 >Number: 173857 >Category: conf >Synopsis: Mistake in newsyslog.conf >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri Nov 23 09:40:00 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Matt Smith >Release: 9.1-RC3 >Organization: >Environment: FreeBSD tao.xtaz.co.uk 9.1-RC3 FreeBSD 9.1-RC3 #0 r242431M: Thu Nov 1 17:49:06 GMT 2012 root@tao.xtaz.co.uk:/usr/obj/usr/src/sys/TAO amd64 >Description: Discussed in forum here: http://forums.freebsd.org/showthread.php?t=35910 I believe there is a mistake in the /etc/newsyslog.conf. The line for rotating the weekly.log has a 1 in the size field where I believe this should be a *. This results in the reason for the log rotation always being because size <1K whereas because it's a log that's designed to be rotated weekly shouldn't this be based on the when clause rather than the size as the daily and monthly ones are? I apologise if this is done intentionally for some reason, but it seems odd to me and somebody on the forum agreed and so I have filed a PR. >How-To-Repeat: Enable the weekly.log in periodic.conf and observe when it gets rotated and the reason for the rotation given at the top of the log file. >Fix: Change the 1 under the size field for the weekly.log to a * Patch attached with submission follows: --- newsyslog.conf.old 2012-11-23 09:28:33.000000000 +0000 +++ newsyslog.conf 2012-11-23 09:28:42.000000000 +0000 @@ -34,5 +34,5 @@ /var/log/security 600 10 100 * JC /var/log/sendmail.st 640 10 * 168 B /var/log/utx.log 644 3 * @01T05 B -/var/log/weekly.log 640 5 1 $W6D0 JN +/var/log/weekly.log 640 5 * $W6D0 JN /var/log/xferlog 600 7 100 * JC >Release-Note: >Audit-Trail: >Unformatted: