From owner-p4-projects@FreeBSD.ORG Tue Feb 3 20:37:38 2015 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 1A9FAA01; Tue, 3 Feb 2015 20:37:38 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id CE9529FE; Tue, 3 Feb 2015 20:37:37 +0000 (UTC) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A9A93AC2; Tue, 3 Feb 2015 20:37:37 +0000 (UTC) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id AA250B95B; Tue, 3 Feb 2015 15:37:36 -0500 (EST) From: John Baldwin To: "John-Mark Gurney" Subject: Re: PERFORCE change 1205651 for review Date: Tue, 3 Feb 2015 15:37:02 -0500 User-Agent: KMail/1.13.5 (FreeBSD/8.4-CBSD-20140415; KDE/4.5.5; amd64; ; ) References: <201502030012.t130Cnni073962@skunkworks.freebsd.org> In-Reply-To: <201502030012.t130Cnni073962@skunkworks.freebsd.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201502031537.02953.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Tue, 03 Feb 2015 15:37:36 -0500 (EST) Cc: Perforce Change Reviews X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Feb 2015 20:37:38 -0000 On Monday, February 02, 2015 7:12:49 pm John-Mark Gurney wrote: > http://p4web.freebsd.org/@@1205651?ac=10 > > Change 1205651 by jmg@jmg_pciehp on 2015/02/03 00:12:18 > > Add inital work to make PCIe HotPlug work... This has been tested > w/: > > uart3: port 0x3000-0x3007 at device 0.0 on pci2 > uart4: port 0x3008-0x300f at device 0.1 on pci2 > > uart3: detached > uart4: detached > > uart3: port 0x3000-0x3007 at device 0.0 on pci2 > uart4: port 0x3008-0x300f at device 0.1 on pci2 > > This work is based upon gavin's project branch, but fixed > to make some things work.. > > Right now there is a nasty bit as we don't have a way for a > non-acpi driver to add a new PCI device, so the code hard codes > the extra space necessary for ACPI... This will be fixed by > adding necessary bus functions to tell ACPI to rescan the bus, > etc... Note that Ryan already had to solve this problem for SRIOV, and I think his solution will work fine. In particular, you can have a pci_if.m method that the bus drivers implement that is something like 'pci_add_device()' to tell it about the new device(s) it needs to rescan without forcing an entire bus rescan (though a bus rescan might be useful for other reasons). > +/* Interesting values for PCIe Hotplug */ > +struct pcicfg_hp { > + struct task hp_inttask; > + struct callout_handle hp_dllhndl; > + int hp_cnt; /* Giant locked */ > + uint32_t hp_slotcap; /* cache this */ > +}; Do not use a callout_handle. timeout() is about to be removed from the tree (there is only one consumer left). Use a struct callout instead. -- John Baldwin