From owner-freebsd-net@FreeBSD.ORG  Wed Nov 28 01:27:21 2007
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 9E71716A420
	for <freebsd-net@freebsd.org>; Wed, 28 Nov 2007 01:27:21 +0000 (UTC)
	(envelope-from nick-lists@netability.ie)
Received: from mail.acquirer.com (mail.acquirer.com [87.198.142.10])
	by mx1.freebsd.org (Postfix) with ESMTP id 2745E13C448
	for <freebsd-net@freebsd.org>; Wed, 28 Nov 2007 01:27:20 +0000 (UTC)
	(envelope-from nick-lists@netability.ie)
X-Envelope-To: freebsd-net@freebsd.org
Received: from crumpet.foobar.org (twinkie.foobar.org [87.192.56.84])
	(authenticated bits=0)
	by mail.acquirer.com (8.13.6/8.13.8) with ESMTP id lAS1R8nM038709
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Wed, 28 Nov 2007 01:27:14 GMT
	(envelope-from nick-lists@netability.ie)
Message-ID: <474CC3EC.1010205@netability.ie>
Date: Wed, 28 Nov 2007 01:27:08 +0000
From: Nick Hilliard <nick-lists@netability.ie>
User-Agent: Thunderbird 2.0.0.9 (Macintosh/20071031)
MIME-Version: 1.0
To: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net>
References: <474B24F3.2030603@netability.ie>
	<20071126224649.C53707@maildrop.int.zabbadoz.net>
In-Reply-To: <20071126224649.C53707@maildrop.int.zabbadoz.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00 autolearn=ham
	version=3.2.1
X-Spam-Checker-Version: SpamAssassin 3.2.1 (2007-05-02) on muffin.acquirer.com
X-Virus-Scanned: ClamAV 0.91.2/4934/Tue Nov 27 23:17:17 2007 on
	muffin.acquirer.com
X-Virus-Status: Clean
Cc: freebsd-net@freebsd.org
Subject: Re: tcp md5 checksums broken in 7.0-beta3
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 28 Nov 2007 01:27:21 -0000

Bjoern A. Zeeb wrote:
> I'll try to find your bug the next days (in case you find anything let
> me know).

At the very least, this will be necessary:

--- tcp_subr.c~        2007-11-28 01:14:46.000000000 +0000
+++ tcp_subr.c  2007-11-28 01:14:46.000000000 +0000
@@ -1948,7 +1948,7 @@
        /*
         * Step 4: Update MD5 hash with shared secret.
         */
-       MD5Update(&ctx, _KEYBUF(sav->key_auth), _KEYLEN(sav->key_auth));
+       MD5Update(&ctx, sav->key_auth->key_data, _KEYLEN(sav->key_auth));
        MD5Final(buf, &ctx);

        key_sa_recordxfer(sav, m);

But it doesn't fix the problem.

Nick