From owner-freebsd-scsi@FreeBSD.ORG  Tue Jul 23 21:41:29 2013
Return-Path: <owner-freebsd-scsi@FreeBSD.ORG>
Delivered-To: scsi@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id 7B66EA38;
 Tue, 23 Jul 2013 21:41:29 +0000 (UTC) (envelope-from uqs@FreeBSD.org)
Received: from acme.spoerlein.net (acme.spoerlein.net
 [IPv6:2a01:4f8:131:23c2::1])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 1887926E0;
 Tue, 23 Jul 2013 21:41:28 +0000 (UTC)
Received: from localhost (acme.spoerlein.net [IPv6:2a01:4f8:131:23c2::1])
 by acme.spoerlein.net (8.14.7/8.14.7) with ESMTP id r6NLfRcU022940
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
 Tue, 23 Jul 2013 23:41:27 +0200 (CEST)
 (envelope-from uqs@FreeBSD.org)
Date: Tue, 23 Jul 2013 23:41:27 +0200
From: Ulrich =?utf-8?B?U3DDtnJsZWlu?= <uqs@FreeBSD.org>
To: "Justin T. Gibbs" <gibbs@FreeBSD.org>
Subject: Re: Please review patch for aic7xxx_pci.c
Message-ID: <20130723214126.GG9030@acme.spoerlein.net>
References: <20130716094927.GA9030@acme.spoerlein.net>
 <20130723071129.GD9030@acme.spoerlein.net>
 <FBF11F26-4083-4F7C-AEC6-054E369A1A25@FreeBSD.org>
 <20130723204530.GE9030@acme.spoerlein.net>
 <86E509ED-694D-49B0-A3D9-C9C7B71F67CE@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <86E509ED-694D-49B0-A3D9-C9C7B71F67CE@FreeBSD.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: scsi@freebsd.org
X-BeenThere: freebsd-scsi@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SCSI subsystem <freebsd-scsi.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-scsi>,
 <mailto:freebsd-scsi-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-scsi>
List-Post: <mailto:freebsd-scsi@freebsd.org>
List-Help: <mailto:freebsd-scsi-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-scsi>,
 <mailto:freebsd-scsi-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Jul 2013 21:41:29 -0000

On Tue, 2013-07-23 at 15:15:53 -0600, Justin T. Gibbs wrote:
> On Jul 23, 2013, at 2:45 PM, Ulrich Spörlein <uqs@freebsd.org> wrote:
> 
> > Thanks, but maybe it's better to have the discussion here.
> > 
> > You wrote:
> > The difference in the argument order between the declaration and definition is
> > likely what led to this programming error. Your patch should also correct the
> > argument reversal in the declaration of ahc_9005_subdevinfo_valid().
> > 
> > The argument order you've used seems the best choice since it matches what is
> > used in ahc_compose_id().
> > 
> > 
> > 
> > I'm not sure that reversing the arguments in the function definition is
> > the right way. This would make the patch a no-op.
> 
> Read the quote again.  I said change the "declaration", not the
> "definition".  To be extremely clear, the code currently looks like
> this:

D'oh, that's what I get for reading too fast. I've opted to change the
function definition, in the end, so that declaration, definition and
call-site are in sync, see
https://github.com/uqs/freebsd-head/commit/e699b2fde01f235a22e1125e9f3aef16623b512f

Thanks!
Uli