From owner-svn-src-all@FreeBSD.ORG  Thu Jan 31 20:01:46 2013
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id A2326AFA;
 Thu, 31 Jan 2013 20:01:46 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from bigwig.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net
 [IPv6:2001:470:1f10:75::2])
 by mx1.freebsd.org (Postfix) with ESMTP id 7F5F6E6E;
 Thu, 31 Jan 2013 20:01:46 +0000 (UTC)
Received: from pakbsde14.localnet (unknown [38.105.238.108])
 by bigwig.baldwin.cx (Postfix) with ESMTPSA id B1E85B94B;
 Thu, 31 Jan 2013 15:01:45 -0500 (EST)
From: John Baldwin <jhb@freebsd.org>
To: Pietro Cerutti <gahr@freebsd.org>
Subject: Re: svn commit: r246120 - in head: include lib/libc/stdio
 tools/regression/lib/libc/stdio
Date: Thu, 31 Jan 2013 15:01:39 -0500
User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p22; KDE/4.5.5; amd64; ; )
References: <201301301459.r0UExQKw074249@svn.freebsd.org>
 <201301311123.09015.jhb@freebsd.org>
In-Reply-To: <201301311123.09015.jhb@freebsd.org>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <201301311501.39671.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7
 (bigwig.baldwin.cx); Thu, 31 Jan 2013 15:01:45 -0500 (EST)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 31 Jan 2013 20:01:46 -0000

On Thursday, January 31, 2013 11:23:08 am John Baldwin wrote:
> On Wednesday, January 30, 2013 9:59:26 am Pietro Cerutti wrote:
> > +static fpos_t
> > +fmemopen_seek (void *cookie, fpos_t offset, int whence)
> > +{
> > +	struct __fmemopen_cookie *ck = cookie;
> > +
> > +
> > +	switch (whence) {
> > +	case SEEK_SET:
> > +		if (offset > ck->len) {
> > +			errno = EINVAL;
> > +			return (-1);
> 
> This should return POS_ERR on failure.

I'm wrong on this one.  POS_ERR is internal to fseek.c and the funopen()
manpage is clear that -1 should be returned in this case.

-- 
John Baldwin