From owner-cvs-all@FreeBSD.ORG  Wed May 28 15:04:31 2008
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 168CB106567A;
	Wed, 28 May 2008 15:04:31 +0000 (UTC) (envelope-from bms@FreeBSD.org)
Received: from out1.smtp.messagingengine.com (out1.smtp.messagingengine.com
	[66.111.4.25]) by mx1.freebsd.org (Postfix) with ESMTP id D2C5E8FC19;
	Wed, 28 May 2008 15:04:30 +0000 (UTC) (envelope-from bms@FreeBSD.org)
Received: from compute2.internal (compute2.internal [10.202.2.42])
	by out1.messagingengine.com (Postfix) with ESMTP id 0E7E71100A5;
	Wed, 28 May 2008 11:04:30 -0400 (EDT)
Received: from heartbeat1.messagingengine.com ([10.202.2.160])
	by compute2.internal (MEProxy); Wed, 28 May 2008 11:04:30 -0400
X-Sasl-enc: OgDaDCDVT0PD1OZFb8JB4TnP8YkEUvMVGXtJQOQNfd4z 1211987069
Received: from empiric.lon.incunabulum.net
	(82-35-112-254.cable.ubr07.dals.blueyonder.co.uk [82.35.112.254])
	by mail.messagingengine.com (Postfix) with ESMTPSA id EF47C3245;
	Wed, 28 May 2008 11:04:28 -0400 (EDT)
Message-ID: <483D747C.6040008@FreeBSD.org>
Date: Wed, 28 May 2008 16:04:28 +0100
From: "Bruce M. Simpson" <bms@FreeBSD.org>
User-Agent: Thunderbird 2.0.0.14 (X11/20080514)
MIME-Version: 1.0
To: Antoine Brodin <antoine@FreeBSD.org>
References: <200805271833.m4RIXI2Y021272@repoman.freebsd.org>
	<1211975749.93683.21.camel@buffy.york.ac.uk>
In-Reply-To: <1211975749.93683.21.camel@buffy.york.ac.uk>
X-Enigmail-Version: 0.95.6
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: cvs-src@FreeBSD.org, Gavin Atkinson <gavin@FreeBSD.org>,
	cvs-all@FreeBSD.org, src-committers@FreeBSD.org
Subject: Re: cvs commit: src/sys/net if_media.h
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 28 May 2008 15:04:31 -0000

Gavin Atkinson wrote:
> On Tue, 2008-05-27 at 18:33 +0000, Antoine Brodin wrote:
>>
>>   MFC to RELENG_6:
>>     Move "1000baseT" from IFM_SUBTYPE_ETHERNET_DESCRIPTIONS to
>>     IFM_SUBTYPE_ETHERNET_ALIASES: there is already "1000baseTX" in
>>     IFM_SUBTYPE_ETHERNET_DESCRIPTIONS.  This doesn't change ifconfig
>>     behaviour.
>>     
>
> I'm not sure if this is any more correct than it was before.  1000baseT
> and 1000baseTX are incompatible standards.
>
> See http://docs.FreeBSD.org/cgi/mid.cgi?20050307191901.H32508 for an
> example of where this has come up before.  The real bug is probably that
> we claim to support 1000baseTX at all.
>   

That sounds pretty clear to me. Perhaps this change should be backed out 
and done the other way around (make 1000baseTX the alias) ?