From owner-cvs-all@FreeBSD.ORG  Thu Jan 29 05:36:58 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 3956E16A4CE; Thu, 29 Jan 2004 05:36:58 -0800 (PST)
Received: from gvr.gvr.org (gvr-gw.gvr.org [80.126.103.228])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 59C4D43D3F; Thu, 29 Jan 2004 05:36:56 -0800 (PST)
	(envelope-from guido@gvr.org)
Received: by gvr.gvr.org (Postfix, from userid 657)
	id 6DD6D41; Thu, 29 Jan 2004 14:36:55 +0100 (CET)
Date: Thu, 29 Jan 2004 14:36:55 +0100
From: Guido van Rooij <guido@gvr.org>
To: Ruslan Ermilov <ru@FreeBSD.org>
Message-ID: <20040129133655.GA22944@gvr.gvr.org>
References: <200401291316.i0TDGpbj052050@repoman.freebsd.org>
	<20040129132732.GB19899@FreeBSD.org.ua>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20040129132732.GB19899@FreeBSD.org.ua>
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sbin/mount mount.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Jan 2004 13:36:58 -0000

On Thu, Jan 29, 2004 at 03:27:32PM +0200, Ruslan Ermilov wrote:
> On Thu, Jan 29, 2004 at 05:16:51AM -0800, Guido van Rooij wrote:
> > guido       2004/01/29 05:16:51 PST
> > 
> >   FreeBSD src repository
> > 
> >   Modified files:
> >     sbin/mount           mount.c 
> >   Log:
> >   Unbreak -o fstab and -o current in combination with -a
> >   
> >   MFC after:      2 weeks
> >   
> >   Revision  Changes    Path
> >   1.59      +2 -0      src/sbin/mount/mount.c
> > 
> Did you mean -u here, because -a is not listed as allowed
> in combination with the -o option?
> 

Does it matter?

In case it is not with -u, and the filessytem is already mounted,
the mount will not do anything due to:
                                if (!(init_flags & MNT_UPDATE) &&
                                    ismounted(fs, mntbuf, mntsize))
                                        continue;

In case it is not mounted, -o current will be void, and -o fstab
will be implied.

-Guido