From owner-p4-projects@FreeBSD.ORG Wed Jun 14 20:52:08 2006 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 4D7F516A47A; Wed, 14 Jun 2006 20:52:08 +0000 (UTC) X-Original-To: perforce@freebsd.org Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F104716A41A; Wed, 14 Jun 2006 20:52:07 +0000 (UTC) (envelope-from jb@what-creek.com) Received: from what-creek.com (what-creek.com [66.111.37.70]) by mx1.FreeBSD.org (Postfix) with ESMTP id AD80143D49; Wed, 14 Jun 2006 20:52:07 +0000 (GMT) (envelope-from jb@what-creek.com) Received: by what-creek.com (Postfix, from userid 102) id 3221078C1D; Wed, 14 Jun 2006 20:52:05 +0000 (GMT) Date: Wed, 14 Jun 2006 20:52:05 +0000 From: John Birrell To: John Baldwin Message-ID: <20060614205205.GA86553@what-creek.com> References: <200606130047.k5D0liTa052536@repoman.freebsd.org> <200606130930.46610.jhb@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200606130930.46610.jhb@freebsd.org> User-Agent: Mutt/1.4.2.1i Cc: perforce@freebsd.org Subject: Re: PERFORCE change 99099 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Jun 2006 20:52:08 -0000 On Tue, Jun 13, 2006 at 09:30:46AM -0400, John Baldwin wrote: > On Monday 12 June 2006 20:47, John Birrell wrote: > > http://perforce.freebsd.org/chv.cgi?CH=99099 > > > > Change 99099 by jb@jb_freebsd2 on 2006/06/13 00:47:28 > > > > Add hooks for DTrace to register a function to be called when > > the scheduler chooses a new thread to run. This is required for > > DTrace vtime. > > You should probably do this in mi_switch() in kern_synch.c rather than > in this macro. Looking further at this is seems that the code actually has to be inserted into each scheduler just before the call to cpu_switch because the schedulers are each capable of selecting a new thread right up to that time (see sched_switch). -- John Birrell