From owner-freebsd-current Mon Dec 18 9:42:26 2000 From owner-freebsd-current@FreeBSD.ORG Mon Dec 18 09:42:24 2000 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from pike.osd.bsdi.com (pike.osd.bsdi.com [204.216.28.222]) by hub.freebsd.org (Postfix) with ESMTP id 6289837B400 for ; Mon, 18 Dec 2000 09:42:24 -0800 (PST) Received: from foo.osd.bsdi.com (root@foo.osd.bsdi.com [204.216.28.137]) by pike.osd.bsdi.com (8.11.1/8.9.3) with ESMTP id eBIHgNE12260; Mon, 18 Dec 2000 09:42:23 -0800 (PST) (envelope-from jhb@foo.osd.bsdi.com) Received: (from jhb@localhost) by foo.osd.bsdi.com (8.11.1/8.11.0) id eBIHfAY82453; Mon, 18 Dec 2000 09:41:10 -0800 (PST) (envelope-from jhb) Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <25651.977121415@critter> Date: Mon, 18 Dec 2000 09:41:10 -0800 (PST) Organization: BSD, Inc. From: John Baldwin To: Poul-Henning Kamp Subject: Re: test/review: /dev/console logging patch Cc: current@FreeBSD.ORG Sender: jhb@foo.osd.bsdi.com Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On 18-Dec-00 Poul-Henning Kamp wrote: > In message , John Baldwin writes: >> >>On 17-Dec-00 Poul-Henning Kamp wrote: >>> >>> This patch is for the printf(9), log(9) & /dev/console stuff. >>> The result is that you can watch the output from /etc/rc in >>> your /var/log/messages. >>> >>> Poul-Henning >>> >>> >>> 1. Replace logwakeup() with msgbuftrigger++; There is little >>> point in calling a function to set a flag. >> >>Abstraction to keep other code from having to know the iternals of the log(9) >>device? Maybe use a #define for logwakeup() that does the msgbuftrigger++ to >>keep the abstraction w/o the overhead? > > But it was actually the other way around now :-) It was the log > device which had obfuscated the log/printf code because it needed > it's assistance to call selwakeup. > > I want the log/printf code to be as simple as possible, and to have > the smallest stack footprint possible... Ok, works for me. :) -- John Baldwin -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.Baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message