From owner-cvs-all@FreeBSD.ORG Mon Jul 19 17:22:45 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6EFAF16A4CE; Mon, 19 Jul 2004 17:22:45 +0000 (GMT) Received: from smtp2.server.rpi.edu (smtp2.server.rpi.edu [128.113.2.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0232143D1D; Mon, 19 Jul 2004 17:22:45 +0000 (GMT) (envelope-from drosih@rpi.edu) Received: from [128.113.24.47] (gilead.netel.rpi.edu [128.113.24.47]) by smtp2.server.rpi.edu (8.13.0/8.13.0) with ESMTP id i6JHMgDK003944; Mon, 19 Jul 2004 13:22:43 -0400 Mime-Version: 1.0 X-Sender: drosih@mail.rpi.edu Message-Id: In-Reply-To: <200407190925.56489.jhb@FreeBSD.org> References: <200407190621.i6J6LRWJ019976@repoman.freebsd.org> <20040719071147.GS18577@cs.rice.edu> <20040719103917.GD1038@green.homeunix.org> <200407190925.56489.jhb@FreeBSD.org> Date: Mon, 19 Jul 2004 13:22:41 -0400 To: John Baldwin , Brian Fundakowski Feldman From: Garance A Drosihn Content-Type: text/plain; charset="us-ascii" ; format="flowed" X-Scanned-By: CanIt (www . canit . ca) cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys malloc.h src/sys/kern kern_malloc.c src/sys/vm vm_contig.c vm_page.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Jul 2004 17:22:45 -0000 At 9:25 AM -0400 7/19/04, John Baldwin wrote: >On Monday 19 July 2004 06:39 am, Brian Fundakowski Feldman wrote: > > > > Aye, I didn't feel totally comfortable saying "Reviewed by:" since > > that was a while ago, ... > >For future reference: In this case I usually add a line along the >lines of: > >Reviewed by: bde (an earlier version) > >Which is both truthful and avoids the ensuing flamewar due to >the appearance of an unreviewed driveby. :) This sounds like a good method to follow. Another thing to say is "by silence on freebsd-blah", so that you document that others had a chance to review it, but no one picked up on the opportunity. -- Garance Alistair Drosehn = gad@gilead.netel.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu