From owner-freebsd-stable  Mon May 13  9:38:51 2002
Delivered-To: freebsd-stable@freebsd.org
Received: from apollo.backplane.com (apollo.backplane.com [216.240.41.2])
	by hub.freebsd.org (Postfix) with ESMTP id 00CBF37B400
	for <stable@FreeBSD.ORG>; Mon, 13 May 2002 09:38:48 -0700 (PDT)
Received: from apollo.backplane.com (localhost [127.0.0.1])
	by apollo.backplane.com (8.12.3/8.9.1) with ESMTP id g4DGcdhU068501;
	Mon, 13 May 2002 09:38:39 -0700 (PDT)
	(envelope-from dillon@apollo.backplane.com)
Received: (from dillon@localhost)
	by apollo.backplane.com (8.12.3/8.12.3/Submit) id g4DGcc72068498;
	Mon, 13 May 2002 09:38:38 -0700 (PDT)
Date: Mon, 13 May 2002 09:38:38 -0700 (PDT)
From: Matthew Dillon <dillon@apollo.backplane.com>
Message-Id: <200205131638.g4DGcc72068498@apollo.backplane.com>
To: Bruce Campbell <bruce@engmail.uwaterloo.ca>
Cc: Danny Schales <dan@coes.LaTech.edu>,
	Rolandas Naujikas <rolnas@takas.lt>,
	Doug White <dwhite@resnet.uoregon.edu>,
	Wilko Bulte <wkb@freebie.xs4all.nl>,
	Paul Horechuk <phorechuk@docucom.ca>, stable@FreeBSD.ORG
Subject: Re: nfs_fsync: not dirty  error in 4.5-RELEASE (possible solution)
References:  <Pine.GSO.4.05.10205130845380.4982-100000@engmail.uwaterloo.ca>
Sender: owner-freebsd-stable@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-stable.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-stable>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-stable>
X-Loop: FreeBSD.ORG

    Excellent!  Thanks for the confirmation, Bruce.  I comitted this
    patch on April 3rd after getting positive results from Danny, but it's
    always nice to have independant confirmation that a bugs been fixed!

					-Matt
					Matthew Dillon 
					<dillon@backplane.com>


:I've been running the patch below now for almost a month on 3 separate
:systems, with no problems now.
:
:These 3 systems had previously experienced about 10 "nfs_fsync: not dirty"
:panics since they had been installed just 3 weeks prior.
:
:My analysis of 10 panics in 3 weeks versus 0 panics in 4 weeks makes
:me suspect the problem has been fixed with the patch below.
:
:...
:>     I believe that the correct fix is to change this code to:
:>     
:>         /*
:>          * If B_INVAL, clear B_DELWRI.  We've already placed the buffer
:>          * on the correct queue.
:>          */
:>         if ((bp->b_flags & (B_INVAL|B_DELWRI)) == (B_INVAL|B_DELWRI))
:> 		bundirty(bp);
:> 
:> 					-Matt

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-stable" in the body of the message