From owner-cvs-all@FreeBSD.ORG Wed Oct 1 05:11:47 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C856516A4B3; Wed, 1 Oct 2003 05:11:47 -0700 (PDT) Received: from duke.cs.duke.edu (duke.cs.duke.edu [152.3.140.1]) by mx1.FreeBSD.org (Postfix) with ESMTP id B2A1843FCB; Wed, 1 Oct 2003 05:11:46 -0700 (PDT) (envelope-from gallatin@cs.duke.edu) Received: from grasshopper.cs.duke.edu (grasshopper.cs.duke.edu [152.3.145.30]) by duke.cs.duke.edu (8.12.10/8.12.10) with ESMTP id h91CBjGN007225 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO); Wed, 1 Oct 2003 08:11:45 -0400 (EDT) Received: (from gallatin@localhost) by grasshopper.cs.duke.edu (8.11.6/8.9.1) id h91CBeY06661; Wed, 1 Oct 2003 08:11:40 -0400 (EDT) (envelope-from gallatin@cs.duke.edu) From: Andrew Gallatin MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <16250.50300.605135.196381@grasshopper.cs.duke.edu> Date: Wed, 1 Oct 2003 08:11:40 -0400 (EDT) To: Bruce M Simpson In-Reply-To: <20031001024035.GB6471@saboteur.dek.spc.org> References: <200310010121.h911LbnC044557@repoman.freebsd.org> <20031001024035.GB6471@saboteur.dek.spc.org> X-Mailer: VM 6.75 under 21.1 (patch 12) "Channel Islands" XEmacs Lucid cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/vm vm_map.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Oct 2003 12:11:48 -0000 Bruce M Simpson writes: > On Tue, Sep 30, 2003 at 06:21:37PM -0700, Andrew Gallatin wrote: > ... > > without first setting it to start_entry. Naturally, the second loop > > is never entered and the pages backing the entries are never unwired. > > This can lead to a leak of wired pages. > > Well spotted... *pats on back* ;) Thanks. But it was kind of hard not to notice when our Myrinet driver (which uses vm_map_user_pageable()) suddenly started to leak wired memory.. Drew