From owner-cvs-all Tue Sep 3 22:30:32 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0187C37B405; Tue, 3 Sep 2002 22:30:20 -0700 (PDT) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3372F43E3B; Tue, 3 Sep 2002 22:30:19 -0700 (PDT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.3/8.12.2) with ESMTP id g845UBvV095961; Wed, 4 Sep 2002 07:30:12 +0200 (CEST) (envelope-from phk@critter.freebsd.dk) To: "M. Warner Losh" Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/pccard pccard.c In-Reply-To: Your message of "Tue, 03 Sep 2002 20:40:42 MDT." <20020903.204042.23985384.imp@bsdimp.com> Date: Wed, 04 Sep 2002 07:30:11 +0200 Message-ID: <95960.1031117411@critter.freebsd.dk> From: Poul-Henning Kamp Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message <20020903.204042.23985384.imp@bsdimp.com>, "M. Warner Losh" writes: >In message: <68113.1031052593@critter.freebsd.dk> > Poul-Henning Kamp writes: >: In message <200209031124.g83BOPAh090297@freefall.freebsd.org>, Poul-Henning Kam >: p writes: >: >phk 2002/09/03 04:24:25 PDT >: > >: > Modified files: >: > sys/dev/pccard pccard.c >: > Log: >: > Drop another cookie to wet Warners appetite: >: > >: > We need to call the drivers interrupt function even though the card is not >: > multifunction. >: >: This should make interrupt handling work on non-multifunction cards. > >They already work on non mfc cards. The changes will make it work on >more MFC cards. most mfc cards don't implement the registers, so they >read as 0xff and a write is a noop. The non-mfc cards that implement >these registers are the only ones that this fixes :-) > >Otherwise, how would most cards work, which aren't mfc? I don't trust the "read as 0xff" bit in the above statement... -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message