From owner-cvs-src@FreeBSD.ORG Sat Jun 16 09:25:24 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 40A7716A400; Sat, 16 Jun 2007 09:25:24 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 17D0113C483; Sat, 16 Jun 2007 09:25:24 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l5G9PNea009087; Sat, 16 Jun 2007 09:25:23 GMT (envelope-from bz@repoman.freebsd.org) Received: (from bz@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l5G9PNC0009086; Sat, 16 Jun 2007 09:25:23 GMT (envelope-from bz) Message-Id: <200706160925.l5G9PNC0009086@repoman.freebsd.org> From: "Bjoern A. Zeeb" Date: Sat, 16 Jun 2007 09:25:23 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netipsec key.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Jun 2007 09:25:24 -0000 bz 2007-06-16 09:25:23 UTC FreeBSD src repository Modified files: sys/netipsec key.c Log: 'spi' and the return value of ntohl are unsigned. Remove the extra >=0 check which was always true. Document the special meaning of spi values of 0 and 1-255 with a comment. Found with: Coverity Prevent(tm) CID: 2047 Revision Changes Path 1.27 +6 -1 src/sys/netipsec/key.c