From owner-freebsd-stable@FreeBSD.ORG  Mon Dec 25 17:14:05 2006
Return-Path: <owner-freebsd-stable@FreeBSD.ORG>
X-Original-To: stable@freebsd.org
Delivered-To: freebsd-stable@FreeBSD.ORG
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 12DAA16A40F
	for <stable@freebsd.org>; Mon, 25 Dec 2006 17:14:05 +0000 (UTC)
	(envelope-from scottl@samsco.org)
Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57])
	by mx1.freebsd.org (Postfix) with ESMTP id C106913C48E
	for <stable@freebsd.org>; Mon, 25 Dec 2006 17:14:04 +0000 (UTC)
	(envelope-from scottl@samsco.org)
Received: from [127.0.0.1] (pooker.samsco.org [168.103.85.57])
	(authenticated bits=0)
	by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id kBPHCE50054589;
	Mon, 25 Dec 2006 10:12:19 -0700 (MST)
	(envelope-from scottl@samsco.org)
Message-ID: <4590066B.8050604@samsco.org>
Date: Mon, 25 Dec 2006 12:12:11 -0500
From: Scott Long <scottl@samsco.org>
User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US;
	rv:1.8.0.7) Gecko/20060910 SeaMonkey/1.0.5
MIME-Version: 1.0
To: Luigi Rizzo <rizzo@icir.org>
References: <20061221092717.A6431@xorpc.icir.org>	<20061222073857.GA10704@tmn.ru>	<20061225165735.M22401@atlantis.atlantis.dp.ua>
	<20061225084704.A23448@xorpc.icir.org>
In-Reply-To: <20061225084704.A23448@xorpc.icir.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-1.4 required=3.8 tests=ALL_TRUSTED autolearn=failed 
	version=3.1.1
X-Spam-Checker-Version: SpamAssassin 3.1.1 (2006-03-10) on pooker.samsco.org
Cc: Dmitry Pryanishnikov <dmitry@atlantis.dp.ua>, stable@freebsd.org
Subject: Re: burncd 'blank' not terminating ?
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Production branch of FreeBSD source code <freebsd-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>, 
	<mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
	<mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 25 Dec 2006 17:14:05 -0000

Luigi Rizzo wrote:
> On Mon, Dec 25, 2006 at 05:12:04PM +0200, Dmitry Pryanishnikov wrote:
>> Hello!
>>
>> On Fri, 22 Dec 2006, Sergey N. Voronkov wrote:
>>>> just noticed, after upgrading to 6.2RC1, that
>>>>
>>>> 	luigi# burncd -f /dev/acd0 -v blank
>>>> 	blanking CD, please wait..
>>>>
>>>> stays there forever. Eventually i gave up and ctrl-C and
>>>> the application terminates, and i was able to write to
>>>> the disk a valid image, which probably means that the
>>>> disk had been blanked.
>>    Yes, well known RELENG_4 -> 6 (maybe even 5) regression. Same here with
>>
>> acd0: CDRW <CD-W540E/1.0C> at ata1-master UDMA33
>>
>> Worked fine under RELENG_4, fails to wait for completion under RELENG_6.
> 
> indeed, the two routines are different: in RELENG_4
> 
>     static int
>     acd_get_progress(struct acd_softc *cdp, int *finished)
>     {
> 	int8_t ccb[16] = { ATAPI_READ_CAPACITY, 0, 0, 0, 0, 0, 0, 0,  
> 			   0, 0, 0, 0, 0, 0, 0, 0 };


My memory is rusty here, but I thought that a TUR was the canonical way 
to test if the operation is complete, and get progress as a side effect.
I see that until rev 1.85, this function used a plain REQUEST_SENSE, 
which was definitely wrong.  There has to be some way that a 
WHQL-qualified disc burner will report this information reliably.

Scott