From owner-freebsd-hackers@FreeBSD.ORG Mon Aug 1 17:49:35 2005 Return-Path: X-Original-To: freebsd-hackers@freebsd.org Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D44F816A420 for ; Mon, 1 Aug 2005 17:49:35 +0000 (GMT) (envelope-from igor@doom.homeunix.org) Received: from voodoo.oberon.net (voodoo.oberon.net [212.118.165.100]) by mx1.FreeBSD.org (Postfix) with ESMTP id A1C2643D76 for ; Mon, 1 Aug 2005 17:49:26 +0000 (GMT) (envelope-from igor@doom.homeunix.org) Received: from dialup84116-56.ip.peterstar.net ([84.204.116.56] helo=doom.homeunix.org) by voodoo.oberon.net with esmtps (TLSv1:AES256-SHA:256) (Exim 4.52 (FreeBSD)) id 1DzePB-000GAk-6K for freebsd-hackers@freebsd.org; Mon, 01 Aug 2005 19:48:50 +0200 Received: from doom.homeunix.org (localhost [127.0.0.1]) by doom.homeunix.org (8.13.3/8.13.3) with ESMTP id j71HmgcL000724; Mon, 1 Aug 2005 21:48:42 +0400 (MSD) (envelope-from igor@doom.homeunix.org) Received: (from igor@localhost) by doom.homeunix.org (8.13.3/8.13.3/Submit) id j6VH86qK012106; Sun, 31 Jul 2005 21:08:06 +0400 (MSD) (envelope-from igor) Date: Sun, 31 Jul 2005 21:08:06 +0400 From: Igor Pokrovsky To: KOMATSU Shinichiro Message-ID: <20050731170806.GA7783@doom.homeunix.org> Mail-Followup-To: KOMATSU Shinichiro , Olivier Certner , freebsd-hackers@freebsd.org, Kris Kennaway , Florent Thoumie References: <200507102313.12719.olivier.certner@free.fr> <20050712165530.GA5475@xor.obsecurity.org> <1121189986.6598.1.camel@cream.xbsd.org> <200507130015.31521.olivier.certner@free.fr> <42EC38C9.8070402@lovepeers.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <42EC38C9.8070402@lovepeers.org> User-Agent: Mutt/1.4.2.1i Cc: freebsd-hackers@freebsd.org, Florent Thoumie , Kris Kennaway Subject: Re: Bug in portupgrade X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Aug 2005 17:49:36 -0000 On Sun, Jul 31, 2005 at 11:34:49AM +0900, KOMATSU Shinichiro wrote: > Hello. > > Olivier Certner wrote: > >Le Mardi 12 Juillet 2005 19:39, Florent Thoumie a ?crit : > > > >>Le Mardi 12 juillet 2005 ? 12:55 -0400, Kris Kennaway a ?crit : > >> > >>>On Sun, Jul 10, 2005 at 11:13:12PM +0200, Olivier Certner wrote: > >>> > >>>> Hi, > >>>> > >>>> There is a bug with portupgrade when it is used to upgrade already > >>>>compiled and installed ports for which some dependencies have been > >>>>deleted in the package database. This causes a crash in the function > >>>>'deorigin' in pkgdb.rb. > >>>> > >>>> Since I don't know the internals of portupgrade, I don't know if it's > >>>>normal to call 'deorigin' with its argument set to nil. If it is, then > >>>>the patch below might be useful (beware, I don't know any ruby, I've > >>>>just tried something and it works), if it is not, I only can provide > >>>>the stack (see below) in order for maintainers to seek the faulty > >>>>callers. > >>> > >>>Please talk to the port maintainer. > >> > >> Yeah, and good luck :) > >> > >> Otherwise, he can try to pkgdb -F or remove pkgdb.rb and re-run > >> portupgrade. > > > > > > This doesn't work in fact. I'm forwarding these mails to the > > maintainer. > > Sorry for my late reply, but would you try out the following patch? > > > Index: lib/portsdb.rb > =================================================================== > --- lib/portsdb.rb (revision 37) > +++ lib/portsdb.rb (revision 38) > @@ -846,7 +846,7 @@ > > def all_depends_list(origin, before_args = nil, after_args = nil) > if !before_args && !after_args && i = port(origin) > - i.all_depends.map { |n| origin(n) } > + i.all_depends.map { |n| origin(n) }.compact > else > all_depends_list!(origin, before_args, after_args) > end > _______________________________________________ > freebsd-hackers@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-hackers > To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.org" Thanks! It works. Does it have a chance to be committed? -ip -- Never leave hold of what you've got until you've got hold of something else.