From owner-freebsd-ports@FreeBSD.ORG  Mon Mar 15 04:26:28 2004
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2586116A4CF
	for <ports@FreeBSD.org>; Mon, 15 Mar 2004 04:26:28 -0800 (PST)
Received: from mtaw6.prodigy.net (mtaw6.prodigy.net [64.164.98.56])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 0A75C43D49
	for <ports@FreeBSD.org>; Mon, 15 Mar 2004 04:26:28 -0800 (PST)
	(envelope-from kris@obsecurity.org)
Received: from obsecurity.dyndns.org
	(d8e2bca7c9d8abe670a7554e2f628807@adsl-67-119-53-203.dsl.lsan03.pacbell.net
	[67.119.53.203])
	by mtaw6.prodigy.net (8.12.10/8.12.10) with ESMTP id i2FCPL3g011857;
	Mon, 15 Mar 2004 04:25:22 -0800 (PST)
Received: by obsecurity.dyndns.org (Postfix, from userid 1000)
	id 25CDF51BFB; Mon, 15 Mar 2004 04:26:22 -0800 (PST)
Date: Mon, 15 Mar 2004 04:26:22 -0800
From: Kris Kennaway <kris@obsecurity.org>
To: Oliver Eikemeier <eikemeier@fillmore-labs.com>
Message-ID: <20040315122621.GA24383@xor.obsecurity.org>
References: <20040315103649.GA13718@xor.obsecurity.org>
	<40558B72.3090409@fillmore-labs.com>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="ZPt4rx8FFjLCG7dd"
Content-Disposition: inline
In-Reply-To: <40558B72.3090409@fillmore-labs.com>
User-Agent: Mutt/1.4.2.1i
cc: ports@FreeBSD.org
cc: Kris Kennaway <kris@obsecurity.org>
Subject: Re: INDEX user-friendliness and SMP speed-up patch
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 15 Mar 2004 12:26:28 -0000


--ZPt4rx8FFjLCG7dd
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Mar 15, 2004 at 11:54:42AM +0100, Oliver Eikemeier wrote:
> Kris Kennaway wrote:
>=20
> >+	if [ "${INDEX_PRISTINE}" !=3D "" ]; then \
> >+		export LOCALBASE=3D/nonexistentlocal; \
> >+		export X11BASE=3D/nonexistentx; \
> >+	fi; \
>=20
> Will you set DEFAULT_OPTIONS=3Dyes here (for PR 64233), or should I test =
for=20
> INDEX_PRISTINE?

Here would probably be the place for it.

> >+	cat $${tmpdir}/${INDEXFILE}.desc.* | perl=20
> >${.CURDIR}/Tools/make_index | \
> >+		sed -e 's/  */ /g' -e 's/|  */|/g' -e 's/  *|/|/g' -e=20
> >"s,$${LOCALBASE},/usr/local," \
> >+			-e "s,$${X11BASE},/usr/X11R6," -e 's./.=01.g' | \
>=20
> Is "s,$${LOCALBASE},/usr/local," "s,$${X11BASE},/usr/X11R6," appropriate
> if INDEX_PRISTINE is not defined?

Good point, I'll change that.

> >+.if defined(BUILDING_INDEX)
> >+describe: ${SUBDIR:S/^/describe./}
> >+
> >+.for i in ${SUBDIR}
> >+describe.$i:
> >+	@${MAKE} -B ${i:S/^/_/:S/$/.describe/} >=20
> >${INDEX_TMPDIR}/${INDEXFILE}.desc.${i}
> >+.endfor
> >+.else
> > describe: ${SUBDIR:S/^/_/:S/$/.describe/}
> >+.endif
>=20
> I always wondered why we don't have
>=20
> .PHONY describe
>=20
> and
>=20
> .PHONY describe.$i
>=20
> here. Any reasons for that?

Hmm, I'm not sure what that would do.

Kris

--ZPt4rx8FFjLCG7dd
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)

iD8DBQFAVaDtWry0BWjoQKURAv/qAJ9iB1trn6r1EIwxKObl58A7c4H+DACfdUWZ
t+J095Xlw41pdx0g/64azg4=
=I67/
-----END PGP SIGNATURE-----

--ZPt4rx8FFjLCG7dd--